Improve description of the auth.gitBasicAuth parameter

This parameter affects all HTTP traffic. Clarify that this is not only
about git over HTTP but also about accessing the REST API.

Change-Id: I15e7dd0489ad8befd079a277dc9578c1d62cb836
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Improve documentation about project creation

The documentation wasn't mentioning that projects can be created in
the Gerrit WebUI and via the REST API.

Change-Id: I79c1892969bd73a8dddc2c506b43a252bd4810bb
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Merge "Improve description of the auth.gitBasicAuth parameter" into stable-2.9
Allow service users to access REST API if auth.gitBasicAuth = true

If auth.gitBasicAuth is set to true in the gerrit.config file all HTTP
traffic is authenticated using standard BasicAuth and the credentials
are validated using the same auth method as configured for the Gerrit
Web UI. E.g. for LDAP this means that users must use their LDAP
password for Git over HTTP and for accessing the REST API.

Service users are technical users that were created by the
create-account SSH command. These users only exist in Gerrit and hence
they do not have any LDAP password. This is why at the moment service
users are not able to make use of the REST API if auth.gitBasicAuth is
set to true.

With this change users that exist only in Gerrit but not in LDAP are
authenticated with their HTTP password from the Gerrit database if
auth.gitBasicAuth is set to true.

Change-Id: I030c8810807ba678c148f7785a64cc5ff25308b8
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Merge "Allow service users to access REST API if auth.gitBasicAuth = true" into stable-2.9
Merge "Improve documentation about project creation" into stable-2.9
Document project options

Change-Id: Id1f4172d8e6f7182c4eb5f0e90913553e6ca1dce
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
rest-api-groups.txt: Correct input examples to use [] for lists

Change-Id: I109bced2f9309dd20a7962d5fdbcd999fa6f87ff
(cherry picked from commit a2bf824fa154b7cb51e8f89df8321d02c25f3425)
Fix REST example for removing included groups from a group

Change-Id: I8047fa702c12150232ebf62bcd16a27eb638c5e8
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Fix: Wrong exception mapping in ReceiveCommmits

When IOException is thrown in insertPatchSet() or
insertChange(), e.g. ClosedByInterruptException thrown
from AutoCommitWriter.manualFlush(), it will be
mapped to OrmException with error message
"Error updating database" by ORM_EXCEPTION, this becomes
misleading when the administrator analyzes the error log.

Fixed. Replaced the ORM_EXCEPTION with INSERT_EXCEPTION.

Change-Id: I49a6dfea7e49df72db775989a3a0501f60db76d2
Add a section about the submit type to the project owner guide

This section provides some help to choose the right submit type.

Change-Id: Iee1d883563fa91f2c1a4de3b00da5c53b847f008
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Merge changes Iee1d8835,Id1f4172d into stable-2.9

* changes:
  Add a section about the submit type to the project owner guide
  Document project options
Merge branch 'stable-2.8' into stable-2.9

* stable-2.8:
  Fix: Wrong exception mapping in ReceiveCommmits
  Fix REST example for removing included groups from a group
  rest-api-groups.txt: Correct input examples to use [] for lists

Change-Id: I36518fec208e4ab101192118aebeb6c5e0d7e34c
More improvements in the change info block UI

On the project settings icon's tooltip, instead of saying "Go to
project", which is a bit ambiguous, say "Go to project settings".

Instead of linking the project name to the project's default dashboard,
link to a project query.

Add a new dashboard icon (from [1]) that links to the dashboard.

[1] https://www.iconfinder.com/icons/169906/chart_dashboard_graph_icon

Change-Id: If3792fc9f42e2dd75b65a5d40a7974556de56df0
Buck: Respect gerrit-gwtui-common dependency for GWT plugins

520f8a9e23b36194192dc15a11d0138b00d787ba extracted gerrit-gwtui-common
from gerrit-gwtui to make it possible to reuse the common UI code from
Gerrit core and plugins.

gerrit_plugin() rule wasn't adjusted to respect the new dependency for
Gerrit plugins that expose GWT modules.

Change-Id: I595b10ac313dabd7776b0ee25ea5b5939ef3e063
Add support for JCE (Java Cryptography Extension) ciphers

Configures the SSHD daemon to enable support the extra strength
ciphers -if- available in the current JRE. These extensions can be
installed by downloading the JCE policy files from Oracle and
following the installation instructions.

Change-Id: Idd934a29b049b61cddadde5bf797514fcbc654d9
Merge "More improvements in the change info block UI" into stable-2.9
ChangeScreen2: Link topic to search all projects

Some users find topic useful to crosslink changes across projects.
Link the topic search to all changes that match the topic name.

Change-Id: I334e31cbf56601a813010fea7ad06308a2c2f0af
Fix confusing new change notifications from self added reviewers

If A.U.Thor creates a code review and Re View Er adds themselves
to the change, Gerrit was emailing out the following message:

  Re View Er has uploaded a new change for review.

    https://....

This is confusing and incorrect. Re View Er simply added themselves
as a reviewer to the code review, they did not upload the change.

The message was caused by sending out an email with no reviewers,
which triggered NewChange.vm to use $fromName as the "author" of
the new change. It never should have sent the email as no code
review was requested.

Change-Id: I76808153565ac27a319968525b31d52f72d929b3
Discontinue comment visibility strategy for new change screen

As explained in this change [1] comment visibility strategy is replaced
by autoOpen(lastReply) strategy and is going to be removed (also from the
database), when old change screen is removed. Mark label for this setting
on my preference screen as "Old Change Screen" only.

[1] https://gerrit-review.googlesource.com/55536

Bug: Issue 2456
Change-Id: I1b36e9d53a8f35ff0f8f1fb793d3082fb5669452