remove warnings
warning: assigned but unused variable - scope_called, path and strexp
Merge pull request #15648 from kuldeepaggarwal/fix-warnings

remove warnings
remove unnecssary require of `to_param`, as `to_query` is already require `to_param`
Merge pull request #15650 from kuldeepaggarwal/remove-unecessary-require

remove unnecssary require of `to_param`, as `to_query` is already require `to_param`
Revert "remove unnecssary require of `to_param`, as `to_query` is already require `to_param`"

Revert "No need to require to_param, it is already required in to_query.rb"

This reverts commits ccdd97662e1fb00c23c90d59f65c091904959561
and d697ee14264a90a39cdbe87857656d8b314ac9b7.

Reason by @jeremy: These requires are not for implementation dependency.
They ensure that requiring array conversions provides to_query, to_param,
and other array conversion behaviors.

The fact that to_query is implemented in terms of to_param is just a
coincidence. If to_query removed its to_param require, then someone
requiring array conversions would no longer have to_param available.

This change removes these intentional dependencies on to_param in favor
of implementation side effects—an undesirable move that's susceptible to
regression.
rm `same_host?`.  The same conditional is two lines down.
Revert "rm `same_host?`.  The same conditional is two lines down."

This reverts commit 79469b4b0c05a50e19699bc9b568042add2d4987.
rm `same_host?`.  The same conditional is two lines down.
Pluck should work with columns of the same name from different tables

The column name given by the adapter doesn't include the table
namespace, so going through the hashed version of the result set causes
overridden keys.

Fixes #15649
Merge pull request #15652 from sgrif/pluck-multiple-named-columns

Pluck should work with columns of the same name from different tables
these methods are always called with a tld_parameter

remove the default parameter since the methods are always called with a
parameter
Updating argument names in default matcher for compiling files

to match arguments used in sprockets-rails [ci skip]
remove useless nil check

irb(main):004:0> /foo/ !~ nil
=> true
irb(main):005:0> /foo/ !~ 'bar'
=> true
irb(main):006:0> /foo/ !~ 'foo'
=> false
There are 3 caveats to Local Precompilation including 1 config change

not 2 caveats with one of them being 2 config changes [ci skip]
pull the port out of the options hash once
scheme should contain one or more characters
only look up the subdomain once
remove useless to_param call

extract_subdomain always returns a string, and to_param calls to_s on a
string
remove unnused method from test
Merge pull request #15656 from JohnRiv/guides_asset_pipeline_precompiling

[ci skip] Updating argument names in default matcher for compiling files