Mike, you can find the default options at
https://github.com/aquynh/capstone/blob/master/config.mk

in there, you can see that by default "USE_SYS_DYN_MEM = yes", which is the
default option we are using for Brew.
therefore, there is no issue with -D_FORTIFY_SOURCE=0, since it never
happens with Brew.

as i mentioned, this option is not for the mass, but specially designed
only for few people who want to embed Capstone into kernel, and they have
to modify source & recompile themselves.

thanks,



On Tue, Mar 11, 2014 at 4:26 PM, Nguyen Anh Quynh <aquynh@gmail.com> wrote:

>
>
>
> On Tue, Mar 11, 2014 at 4:19 PM, Mike McQuaid <notifications@github.com>wrote:
>
>> In Library/Formula/capstone.rb:
>>
>> > @@ -22,12 +22,12 @@ def install
>> >  end
>> >
>> >  __END__
>> > ---- a/Makefile.org	2014-03-05 11:26:42.000000000 +0800
>> > -+++ a/Makefile	2014-03-05 11:28:34.000000000 +0800
>> > -@@ -144,13 +144,6 @@
>> > - ifeq ($(UNAME_S),Darwin)
>> > - EXT = dylib
>> > - AR_EXT = a
>> > +--- a/Makefile.org	2014-03-11 11:51:47.000000000 +0800
>> > ++++ a/Makefile	2014-03-11 11:56:07.000000000 +0800
>> > +@@ -149,13 +149,6 @@
>> > + # remove string check because OS X kernel complains about missing symbols
>> > + CFLAGS += -D_FORTIFY_SOURCE=0
>>
>> As mentioned upstream: I don't approve of this patch, really.
>>
> Mike, let me know if you have a solution for this issue.
>
> this is the fact: Brew package do not have this option, because this
> "remove string ..." above is only for those recompile code from source.
>
> you can double check that Brew package always has "USE_SYS_DYN_MEM = yes",
> and uses can only modify "USE_SYS_DYN_MEM = no" by modifying the source,
> and recompile themselves.
>
> for this reason, there is no security issue with Brew, since we never turn
> that flag off in Brew package.
>
> thanks for understanding.
>
>