Add checkpatch.pl to distribution tarball.

This patch includes checkpatch.pl in the EXTRA_DIST variable in Makefile.am so
that it is included when a tarball is built using "make dist".
WPrefs: add expert option to disable switch panel

This patch is adding a checkbox option in the expert panel
to let the user enable/disable switching panel.
WMaker: src/misc.c remove obsolete code

This patch is removing the call to get_dnd_selection function
which was removed long time ago.
wrlib: load.c clean coding style

just some code cleaning stuff.
WINGs: add function to set the color of the frame title

This patch adds a function used to set the color of the frame title
wmaker: darken labels from docked application settings

This patch darkens DnD labels when support is not compiled in.
wrlib: fix possible incorrect shifting operations (Coverity #50203)

As pointed by Coverity, the shift operation performed for color-to-pixel
transform may not behave as well as expected because of the types used
(Coverity pointing suspicious sign extension because of int type being
involved).

The new code tries to leave no open interpretation to the compiler.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
wrlib: fix possible incorrect shifting operations (Coverity #50204, #50205, #50206)

As pointed by Coverity, the shift operation performed for color-to-pixel
transform may not behave as well as expected because of the types used
(Coverity pointing suspicious sign extension because of int type being
involved).

The new code tries to leave no open interpretation to the compiler.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
wrlib: removed macro RETRY that does not does what is expected (Coverity #50160)

As pointed by Coverity, the behaviour of fopen/fread/fclose in case of
error is not really what the macro RETRY assumes. So the macro is removed
and appropriate action is implemented.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
wrlib: added a limit to the image cache size (Coverity #50223)

As pointed by Coverity, environment variables cannot be considered
trustworthy ("tainted"), so we need to make sure the values provided are
within reasonable bounds for safe operations.

Seized the opportunity to try to provide clearer name for the constants
defining the default value.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
wrlib: initialise value for variable to avoid possible crash (Coverity #50245)

As pointed by Coverity, there's a free on the content of this buffer at
function's end, but if the image's width or height is lower than 1 then we
could reach this free before allocating anything, thus having an
uninitialised pointer.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
wrlib: remove unnecessary variable assignation (Coverity #50258)

As pointed by Coverity, this value is never used, the assignation has no
effect, so Coverity reports that it is unnecessary complexity that is not
compatible with code maintainability.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
wrlib: return NULL if XImage could not be taken, for consistency

To be consistent with RCreateXImage and because it should not be up to the
caller to handle this, when XGetImage returns a NULL pointer then the
function RGetXImage will also return NULL instead of an RXImage structure
with a NULL pointer.

This consistent behaviour helps fixing a memory leak in WMaker reported by
Coverity (#50125).

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
wrlib: new headers to contain definition of internal stuff

Using local function prototype redefinition is dangerous, now a single
prototype is seen in all the files that are concerned.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
wrlib: add explicit type definition in API to allow compiler Type Checks (1/3)

When defining enums as types instead of simple enums allows to use these
types at the places where the corresponding enum values are expected, then
allowing the compiler to check that, potentially reporting incorrect use
of values to the user.

This patch adds types for the configuration fields in the RContextAttributes
structure.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
wrlib: add explicit type definition in API to allow compiler Type Checks (2/3)

When defining enums as types instead of simple enums allows to use these
types at the places where the corresponding enum values are expected, then
allowing the compiler to check that, potentially reporting incorrect use
of values to the user.

This patch adds the types for the drawing operations used by the functions
who drawing shapes into an RImage.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
wrlib: add explicit type definition in API to allow compiler Type Checks (3/3)

When defining enums as types instead of simple enums allows to use these
types at the places where the corresponding enum values are expected, then
allowing the compiler to check that, potentially reporting incorrect use
of values to the user.

This patch adds the type for the gradient style for RRender*Gradient.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>
Consistent terms for switch panel cycling.

The terms "switch panel" and "cycling" have been used in Window Maker
since time immemorial but have not always been applied consistently.
wmaker: redo logo

This patch is providing the logo still in 48x48 size
but with a better definition.
util: simplify the code for 'find_terminal_emulator' (Coverity #50076)

As pointed by Coverity, the code was making an explicit use of a null
pointer, which is certainly not what was initially expected. The code was
simplified to fix the case and to make it easier to understand and
maintain.

Signed-off-by: Christophe CURIS <christophe.curis@free.fr>