bug 1355959 : fix issue of not sending gw & dns server in proper byte order

Change-Id: I0c273729760d872c192efd5f6efcc68c429bd6b4
Fix concurrency issue in BGP state machine test

There were occasional failures in state_machine_test. The root cause
turned out to be a concurrency issue in the test.

In production code, StateMachine::PassiveOpen is called bgp::Config
task and enqueues a EvTcpPassiveOpen event to the WorkQueue. If the
TcpSession is duplicate, the StateMachine will call DeleteSession on
the session.  Since PassiveOpen is called from bgp::Config we are
guaranteed that no other tasks will run before the call finishes.

However, the test code calls StateMachine::PassiveOpen directly from
the main thread (via BgpPeer::AcceptSession). As a consequence, it's
possible that the bgp:StateMachine task runs and calls DeleteSession
on the TcpSession before StateMachine::PassiveOpen has finished.  If
this happens, we could end up accessing the just deleted TcpSession
from StateMachine::PassiveOpen.

Tweak tests to stop the TaskScheduler before a duplicate TcpSession
is enqueued.

Change-Id: I034bf2fae242d135aade2f96c7b77a9188b56b21
Merge "1)Adding Trace when config filter deletes node 2) Removeing tabs"
Merge "Ignore the return value of SetProperty. The SetProperty function is buggy while calculating its return value. There are cases where although there is a change, it will return false. EG: a node with only one property, changing value of an existing property, etc. In this commit, we will ignore the return value of SetProperty since the exporter will continue to use the crc to detect if the content has changed. In a separate commit, we will change the return value of the function to void."
Catch PermissionDenied exception and send appropriate error to neutron when resource_create fails for any resource

Change-Id: Ib55639f51033d501c39348b1aadb76e6f7c3887c
Closes-Bug: 1354830
Fix concurrency issue in routing_instance_test

Use atomic int for notification counts. Since atomic int are not
initialized to 0, move around the calls to ClearCounters so that
we call ClearCounters after a new table is created.

Change-Id: Icf0bbd05a0115b3532320c0a43f1f4fd21f04f86
Merge "Always fetch back refs when reading vmi and use getattr instead of get..back_refs to avoid reading it again"
Re-organize config services test code to be able to run schema transformer test successfully.

Change-Id: I3d6ea93abe64cbc8c0179199ae58f06626f53cdd
Fix UVE unit test cases.

Change-Id: I201f8f30a7db151ba7751994ca2323ba756d77be
Merge "Catch PermissionDenied exception and send appropriate error to neutron when resource_create fails for any resource"
Merge "Fix concurrency issue in BGP state machine test"
Merge "Fix concurrency issue in routing_instance_test"
Currently we set the address mode to active-active if both ip and mac is specified in allowed address pair configuration. This causes ECMP for allowed address pair route.
Set the default address mode to active-standby to address VRRP use case.
Closes-Bug: #1352303
Change-Id: Ib5490301c0bfb78c36ea5373286d36f3b3147bf8
Merge "Verify ASN in OriginVn extended community"
Add a rule-uuid to security group rules if one is not provided by the user

Change-Id: If036847843974dafffc8bc41035c84592bb35add
Closes-Bug: 1355779
If subnet_id is passed at the time of port creation, use it to allocate appropriate ip address. This funcationality was already implemented for port update. With this commit, we are moving common parts to a new function and calling it from both port create and upate

Change-Id: I8cbfd0d3cd4bf59ee0b84752487d4d6bfb995e0f
Closes-Bug: 1349970
Merge "Re-organize config services test code to be able to run schema transformer test successfully."
Merge "Currently we set the address mode to active-active if both ip and mac is specified in allowed address pair configuration. This causes ECMP for allowed address pair route. Set the default address mode to active-standby to address VRRP use case. Closes-Bug: #1352303 Change-Id: Ib5490301c0bfb78c36ea5373286d36f3b3147bf8"
Merge "Add a rule-uuid to security group rules if one is not provided by the user"
Merge "If subnet_id is passed at the time of port creation, use it to allocate appropriate ip address. This funcationality was already implemented for port update. With this commit, we are moving common parts to a new function and calling it from both port create and upate"