Fix check_ssh_injection in cinder/utils

check_ssh_injection is used to prevent commands being modified using
specially constructed strings containing special characters.

The function includes a loop over the special characters to compare
them against each arg. If the special character is the same as the arg
it gets ignored.

This commit modifies this part of the function so that args that are
exactly equal to one of the special characters will cause an exception
to be raised.

Change-Id: I3a61e995ea41fc0324b5cb60e3c96e3d9dc56637
Closes-Bug: #1398002
Raise exception if invalid IP is specified

This patch ensures that all values specified for the configuration
option netapp_controller_ips are valid, rather than logging and
continuing with only the valid addresses.

Closes-Bug: 1396718

Change-Id: I180dc74e4535bfde19f1741cff975f5ec675dd21
Fix find_autodoc_modules.sh to support OSX

When running 'find cinder/' on OSX platforms, all returned paths
will have 2 slashes (//). Because the script only strips
the first slash as per the CINDER_DIR value, we end up
with module names such as "cinder..db.api" in the documentation.

This change trims the leading dot if found to avoid this situation.

Change-Id: I9423b253d9842295850f469757e928bf5856967a
Deal with tgt already exists errors

This patch intends to provide a clear marker for
ER in the case that create export fails due to the
target entry already existing.

Also this patch will enable us to go ahead and just use
the existing target rather than bomb out and fail everything.

Root cause of why we're getting a second create is still
unknown and needs addressed, but this might help in getting
more info as well as keeping things stable until we address
the root issue.

Change-Id: If96f4fab7d9709dbb0726b1dca6237d7bc66ecbe
Partial-Bug: #1398078
Don't use _execute directly in brick/iscsi

The brick/iscsi module has a run helper that
should be used for executing commands.  There
are a number of inconsistencies where _execute
is called directly.

This patch moves everythign to use the run method
to keep things consistent and also to fix up some
potential issues with variables becoming corrupt
under heavy load.

Change-Id: Idfc183f2ed1ad73b64fc893efcc07972c95926c6
Merge "Fix check_ssh_injection in cinder/utils"
Merge "Raise exception if invalid IP is specified"
Remove driver compatibility in volume manager

The old driver locations were deprecated in Juno. This removes the code
for deprecating and tests.

Change-Id: I1e2a985c1b41f4837e316af0655ef7203273cd7a
Merge "Don't use _execute directly in brick/iscsi"
Merge "Deal with tgt already exists errors"
Merge "Fix find_autodoc_modules.sh to support OSX"
Merge "Remove driver compatibility in volume manager"