Add a (currently disabled) test for errors with a chunked response after the response has been committed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600051 13f79535-47bb-0310-9956-ffa450edef68
Clean-up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600101 13f79535-47bb-0310-9956-ffa450edef68
Refactoring.
Switch from a boolean to an Enum for error state so we can differentiate between an error that requires the connection is closed after the current response is completed and an error that requires that the connection is closed immediately.
This commit should be a NO-OP. While the different error states are set, the only the presence of an error (or not) is tested - i.e. no change from the implementation prior to this commit.
Try to be consistent when an error occurs. Set the status code first (if required), then set the error state and finally log (if required).

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600109 13f79535-47bb-0310-9956-ffa450edef68
Formatting.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600161 13f79535-47bb-0310-9956-ffa450edef68
Move resetting of error state to the processor's recycle method.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600162 13f79535-47bb-0310-9956-ffa450edef68
Trivial reformatting to trigger a CI build to see if the CI server is fixed.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600408 13f79535-47bb-0310-9956-ffa450edef68
Improve error handling for an unhandled exception after the response has been committed. Tomcat will now attempt to:
- flush any unwritten response data to the client
- prevent further writes to the response
- close the connection

This means that the client should experience an unclean close that will enable them to differentiate (when chunked encoding is used) between an incomplete response that encountered an error and a complete response that did not (prior to this commit, Tomcat completed the request normally and - depending on the response data written to that point - it may not have been visible to the client that the response was incomplete at that point.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600449 13f79535-47bb-0310-9956-ffa450edef68
Fix regression in r1600449

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600495 13f79535-47bb-0310-9956-ffa450edef68
Add error handling changes.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600501 13f79535-47bb-0310-9956-ffa450edef68
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56588
Remove unnecessary code - essentially revert r1492307 - that is no longer required now that Jasper is initialized via an SCI.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600505 13f79535-47bb-0310-9956-ffa450edef68
Update the error count regardless of how the error flag was set
Ensure that an request can only contribute to the error count once

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600579 13f79535-47bb-0310-9956-ffa450edef68
Fix further regressions in the error handling changes
(r1600449 and r1600495)

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600580 13f79535-47bb-0310-9956-ffa450edef68
Remove null check, as "instanceof" condition on the next line takes care of nulls.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600607 13f79535-47bb-0310-9956-ffa450edef68
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56573
Change the value returned by Session.getRequestURI() from the value obtained from HttpServletRequest.getRequestURI() to the value obtained from HttpServletRequest.getRequestURI() with the scheme changed to ws or wss as appropriate. Note that the WebSocket Expert Group is expected to clarify the expected behaviour for Session.getRequestURI() which may result in further changes.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600651 13f79535-47bb-0310-9956-ffa450edef68
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56573
Restore query string.
Add test cases.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600663 13f79535-47bb-0310-9956-ffa450edef68
Add a test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=56568

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600679 13f79535-47bb-0310-9956-ffa450edef68
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56568
Allow JSP error pages to handle any HTTP method

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600680 13f79535-47bb-0310-9956-ffa450edef68
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56577
Better executor configuration.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600743 13f79535-47bb-0310-9956-ffa450edef68
Don't assume that tests use the StandardManger

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600833 13f79535-47bb-0310-9956-ffa450edef68
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56578
Correct regression in the fix for 56339 that prevented sessions from expiring when using clustering.
The effect of removing expiring = true; from the DeltaSession is that if parallel calls are made to expire() then there is a slightly greater chance of some of those calls blocking while the first completes. This is because expiring is now set to true a little later.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1600839 13f79535-47bb-0310-9956-ffa450edef68