That sounds good.


On 1 April 2014 18:10:52 David Reid <notifications@github.com> wrote:

> > +            ("key1.pem", b"123456"),
> > +            ("key2.pem", b"a123456"),
> > +            ("testrsa.pem", None),
> > +            ("testrsa-encrypted.pem", b"password"),
> > +        ]
> > +    )
> > +    def test_load_pem_private_key(self, key_file, password, backend):
> > +        key = load_vectors_from_file(
> > +            os.path.join("asymmetric", "OpenSSL_Serialization", key_file),
> > +            lambda pemfile: OpenSSLPrivateKey.load_pem(
> > +                pemfile.read().encode(), password, backend
> > +            )
> > +        )
> > +
> > +        assert key
> > +        assert key.private_key
>
> There should be tests that actually assert known properties of the private 
> keys.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/pyca/cryptography/pull/627/files#r11170081