loplugin:implicitboolconversion

Change-Id: I6caec8c11fab5fc8f1318be676e4bdf5f9cdbac5
fdo#83057 File corrupts on save, as SDT is added incorrectly

A fly frame was attached to a para which started within a hint (run) containing an SDT.
This SDT was handled while exporting the FLYFRAME and also the text of the run.
So, eventhough the original file had only one sdt in the header, the RT file had two;
one for a seperate run as expected, and one incorrectly exported in the alternateContent (FLYFRAME)

So don't collect SDTPr from grabbag if the FLY is not processed.
As, the SDT will be handled when the run is exported.

Change-Id: I7b3c94208c171afbec54467fd6b756a6e30c816b
Reviewed-on: https://gerrit.libreoffice.org/11161
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
qadevOOo: remove import from the same package

Change-Id: Id12bece6f1bba0591c3b311553df3fecec40e524
Reviewed-on: https://gerrit.libreoffice.org/11324
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
qadevOOo: reuse the value of entryName.indexOf(Left Parenthesis)

Change-Id: I1950275af2a063db74fef326ac0dd4e555e5170d
Reviewed-on: https://gerrit.libreoffice.org/11323
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Related #82088: removed last css aliases in hxx

* Only unfixed header namespace alias in
  ConnectionLog.hxx:
  LogLevel = ::com::sun::star::logging::LogLevel

Change-Id: I48c941a4762830f2265c8241f4c1695a43ec891a
Reviewed-on: https://gerrit.libreoffice.org/11333
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
sal_Int16 -> FlyProcessingState

Change-Id: Ibbc48711e656a804a5ac6a5651091131bbf81c4f
return RET_CANCEL for ui-previewer

Change-Id: Ic175ae730dc67ae28bb52ee503ee5e572bb4cabc
coverity#1237353 Unchecked dynamic_cast

Change-Id: If25d29eaa788e70972fd0cbbf3d03f4d05862f24
coverity#708008 Uninitialized scalar field

Change-Id: I425b1d822d98cbc28a1d99b41379b0dc5d8e6193
coverity#1237351 Logically dead code

Change-Id: Ia82d8d137c5f36cc48826cc851d6f00626e978aa
coverity#1237355 Dereference null return value

Change-Id: I66956979c494f96f76eb0a7840f28c8edc91d816
coverity#1237357 Uncaught exception

Change-Id: Ie116e0070792c59893ed0b4f41bcf9831400deb9
coverity#704947 Dereference after null check

Change-Id: Id6eb50de48b8a674d7b48d1256b1529637155eb1
Make configure respect --without-system-$lib-for-build

Change-Id: I64cb58e7980de8fdb23f5c0efa75c05a1f0aa904
Reviewed-on: https://gerrit.libreoffice.org/11330
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
drop obsolete configure options

Change-Id: I396998d66bbe4d46b6a19d9ccb3b15d127ead233
scripting: the assigned value is never used

Change-Id: I61dcf285ecc6d0affdb949ca03d686f96601d884
Reviewed-on: https://gerrit.libreoffice.org/11319
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
scripting: if...else if...else Statement

Change-Id: Ia60b352b4cb52d2712b2499550859ece699341d1
Reviewed-on: https://gerrit.libreoffice.org/11322
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
mediawiki: improve storeConfiguration & loadConfiguration methods

* Use enhanced for-loops (storeConfiguration & loadConfiguration)
* Use curly braces to reduce the variable scope and, to reuse variable names (storeConfiguration)
* Avoid map.get(key) in iterations over each map's entry (storeConfiguration):
      for (Map.Entry<String, Object> entry : ht.entrySet())

Change-Id: I678d5a9f205efb2c89ab868b59e1b654419381d8
Reviewed-on: https://gerrit.libreoffice.org/11331
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Presumably, all numeric values shall be written as i4

...in 47c5454ea67632278d69a1ddfe97d74f5cc4449f "fdo#83428: Custom Properties
dropped while exporting to docx," not just ones of UNO type double.  At least,
that fixes CppunitTest_sc_subsequent_export_test's
testPivotTableTwoDataFieldsXLSX to not write a "DocSecurity" <property> without
content (and thus fail validation).

Change-Id: I2d764e65ec2af61139c6564f644d27aa9a00bd7d
Keep files of failing tests around

(Arguably, such files should be stored in a workdir/CppunitTest/... directory
removed and freshly created before every test run, instead of in TMPDIR.)

Change-Id: Ibf1f54fd3d3f9c354c12067e671196e182ef7159