db/db_iter.cc: remove unused variable

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
db/db_test.cc: reduce scope of some variables

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
db/deletefile_test.cc: remove unused variable

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
table/cuckoo_table_reader.cc: pass func parameter by reference

Fix for:

[table/cuckoo_table_reader.cc:196]: (performance) Function
 parameter 'target' should be passed by reference.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
table/format.cc: reduce scope of some variables

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
db/db_test.cc: remove unused variable

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
table/block_based_table_builder.cc: remove unused variable

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
document_db.cc: remove unused variable

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
util/cache_test.cc: use static_cast over C-Style cast

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
db/version_set.cc: remove unnecessary checks

Fix for:

[db/version_set.cc:1219]: (style) Unsigned variable 'last_file'
 can't be negative so it is unnecessary to test it.
[db/version_set.cc:1234]: (style) Unsigned variable 'first_file'
 can't be negative so it is unnecessary to test it.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
ttl/ttl_test.cc: pass const string param by reference

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
document_db_test.cc: pass const string param by reference

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
backupable_db_test.cc: pass const string param by reference

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
resolution for java build problem introduced by 5ec53f3edf62bec1b690ce12fb21a6c52203f3c8
Fixed compile warning on Mac caused by unused variables.

Summary:
Fixed compile warning caused by unused variables.

./db/compaction_picker.h:118:7: error: private field 'max_grandparent_overlap_factor_' is not used [-Werror,-Wunused-private-field]
  int max_grandparent_overlap_factor_;
      ^
./db/compaction_picker.h:119:7: error: private field 'expanded_compaction_factor_' is not used [-Werror,-Wunused-private-field]
  int expanded_compaction_factor_;
      ^
2 errors generated.

Test Plan:
make db_test
Fixed signed-unsigned comparison warning in db_test.cc

Summary:
Fixed signed-unsigned comparison warning in db_test.cc

db/db_test.cc:8606:3: note: in instantiation of function template specialization 'rocksdb::test::Tester::IsEq<int, unsigned long>' requested here
  ASSERT_EQ(2, metadata.size());
    ^

Test Plan:
make db_test
Merge pull request #329 from fyrz/master

resolution for java build problem introduced by 5ec53f3edf62bec1b690ce12...
Merge pull request #327 from dalgaaf/wip-da-SCA-20141001

Fix some issues from SCA