you should update the attributes in the docstring. Then +1 for merge.