Cc pdlogs 61

Updated after review comments for the ENT feature.  
Modified the messages to capitalize acronyms.  
Removed unnecessary whitespace.  
Added full stop to end of each part of the message.  
Actions are numbered if there is more than one action.  This separates the individual actions.
Separated the log definitions with a blank line to make them more readable.  
Ran astyle (according to the coding standards) against sprout_ent_definitions.h.
Fixed header file inconsistencies.
The review comment had: "A lot of the logs still say 'report issue to support' or something similar. This just isn't suitable for Project Clearwater."
The language was kept the same as this is what is done for the SNMP alarm definitions.  The associated documentation should identify the Metaswitch support team for ClearwaterCore and the Clearwater mailing list for Clearwater.
Removed signalnames.cpp.  The signal call name is now obtained from the strsignal call.
It’s the application name.  It will appear in the syslog.  The following is a real log output.  The program name will appear as ‘program-name’[‘pid’].  In this case, sprout[14587].  Sprout-1-plf is the node name.
2014-12-08T17:38:50-06:00 sprout-1-plf err sprout[14587]  2013 - Description: The application did not start a connection to Ralf because Ralf is not enabled. @@Cause: Ralf was not configured in the /etc/clearwater/config file. @@Effect: Billing service will not be available. @@Action: Correct the /etc/clearwater/config file.

I have since amended this message but it was assumed because we are in main.cpp it was sprout (being CC focused).  That would apply to all logs in main.cpp and anything else that is shared.

I guess I was thrown off by the developer logs and comments that have sprout in them.  So, what to do?

David
From: Eleanor Merry [mailto:notifications@github.com]
Sent: Thursday, December 18, 2014 11:37 AM
To: Metaswitch/sprout
Cc: David Collins
Subject: Re: [sprout] Cc pdlogs 61 (#895)


In sprout/main.cpp<https://github.com/Metaswitch/sprout/pull/895#discussion-diff-22057150>:

> @@ -1042,6 +1047,8 @@ int main(int argc, char* argv[])

>    opt.daemon = PJ_FALSE;

>    opt.interactive = PJ_FALSE;

>

> +  openlog("sprout", PDLOG_PID, PDLOG_LOCAL6);

It's the same main.cpp, and we don't know at this point whether we're a Bono or Sprout.
What effect does having 'sprout' here have on syslogs?

—
Reply to this email directly or view it on GitHub<https://github.com/Metaswitch/sprout/pull/895/files#r22057150>.