972110 swimming pool

Changes and additions needed to model indoor swimming pools; this work is ready for review
Edwin:

All of the terms in this equation that are modified by the swimming pool model got bundled together.  So, if it could be modified somehow (like because of the presence of a pool or something happening with the pool cover algorithm), then it was lumped together.  Anything that could NOT be changed, got left alone.  Hopefully that makes sense.  The cover algorithm in particular ended up bring a lot of terms in because it alters what is happening at the surface and this affects various radiation terms.

Rick


On Nov 24, 2014, at 3:56 PM, Edwin Lee <notifications@github.com> wrote:

> In src/EnergyPlus/HeatBalanceSurfaceManager.cc:
> 
> > @@ -5141,10 +5154,14 @@ CalcHeatBalanceInsideSurf( Optional_int_const ZoneToResimulate ) // if passed in
> >  					if ( surface.HeatTransferAlgorithm == HeatTransferModel_EMPD ) {
> >  						CalcMoistureBalanceEMPD( SurfNum, TempSurfInTmp( SurfNum ), TH22, MAT( ZoneNum ), TempSurfInSat );
> >  					}
> > -					Real64 const TempTerm( CTFConstInPart( SurfNum ) + QRadThermInAbs( SurfNum ) + QRadSWInAbs( SurfNum ) + HConvIn( SurfNum ) * RefAirTemp( SurfNum ) + QHTRadSysSurf( SurfNum ) + QHWBaseboardSurf( SurfNum ) + QSteamBaseboardSurf( SurfNum ) + QElecBaseboardSurf( SurfNum ) + NetLWRadToSurf( SurfNum ) );
> @DeadParrot This diff and the next one had to be manually merged because @RKStrand added an IF block for if it isn't a swimming pool, or if it is, and you had tuned the math for performance.
> 
> In your optimization, it wasn't clear to me how you decided to pull out just part of the numerator, but leave a couple terms. It did make sense how you pulled out the divisor into a multiplication. Would you be able to comment here so I can tune the math similarly for the new else-side of this block? This pool model will not be hit very often, but might as well get it in fast to start with.
> 
> Also, the conditions on this IF block hint to me that it will be slow to check all those things every time in. Could you provide comment on this so I know whether we need to clean it up?
> 
> —
> Reply to this email directly or view it on GitHub.
>