Rename was not sorting by entity

The lack of re-targeting PRs in GH is kinda annoying
Yeh, I can't see how it could work without loading too much into memory, or
by not grouping properly.


On Tue, Sep 16, 2014 at 11:29 AM, Russell Aronson <notifications@github.com>
wrote:

> In
> ivory-operation/src/main/scala/com/ambiata/ivory/operation/rename/RenameJob.scala:
>
> >        // Sort by everything, which includes the priority
> > -      job.setSortComparatorClass(classOf[LongLongWritable.Comparator])
> > +      job.setSortComparatorClass(classOf[SnapshotWritable.Comparator])
>
> Yeah, i thought it would be ok, but looking at the docs
> <http://hadoop.apache.org/docs/r2.2.0/api/org/apache/hadoop/mapreduce/Reducer.html>
> im wrong. The groups are just subsets of the sorted data.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ambiata/ivory/pull/273/files#r17579329>.
>