changed the name of this and added doc
more tests