fix generating url
edit url