todo for attrs