fixed params and documented