Fix inventory_ui: calculate weight after dropping.

The partial charges that would have been dropped were never removed from the temporary player object.
Fix pickup weight display (and potentially volume display)

Replaced usage of item::clone() with item assignment operator.

The code would previously work like this:
upon selecting an item to be picked, if that item was not already picked:
add its volume/weight to new_weight/new_volume.
If it was already picked, remove volume/weight from new_weight/new_volume.
But for charges this uses (in both cases!) the new number of charges to be picked.
fix a bug
Indent a chunk of code.
Unify searching for notes and terrain types in the overmap menu. Fixes #8737.
Merge branch 'fix-weight-display' of https://github.com/BevapDin/Cataclysm-DDA into merge3
Merge branch 'unify-note-and-terrain-search' of https://github.com/CleverRaven/Cataclysm-DDA into merge3