Don't hard code the the user id hash, regenerate it so it works on every setup.

Call me an unbeliever, but I prefer explicit returns. They self-document the intended behaviour and use of the method.

On June 14, 2014 10:38:08 PM AEST, Henare Degan <notifications@github.com> wrote:
>>  
>>  module HTMLCompareHelper
>> +  def get_id_hash(user_name)
>> +    text = File.read("../website/config.php")
>> +    text = text[/\$hidden_hash_var[\s]*=[\s]*'.*'/][/'.*'/]
>> +    salt = text[1..text.length-2]
>> +    return Digest::MD5.hexdigest(user_name + salt)
>
>It's more Rubyesque to use an implicit return here.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/openaustralia/publicwhip/pull/186/files#r13780586