ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
https://bugs.webkit.org/show_bug.cgi?id=72057

Reviewed by Eric Seidel.

Make the regular expression more explicit.

* Scripts/webkitpy/common/checkout/changelog.py:
* Scripts/webkitpy/common/checkout/changelog_unittest.py:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=72060
        
[CSS Line Grid] Add support for the line-grid-snap property to control snapping to the nearest
enclosing grid.

Reviewed by Dan Bernstein.

Added fast/line-grid/line-grid-snap-parsing.html.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineGridSnap):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::lineGridSnap):
(WebCore::InheritedFlags::setLineGridSnap):
(WebCore::InheritedFlags::initialLineGridSnap):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=72060
        
Add tests for line-grid-snap parsing.

Reviewed by Dan Bernstein.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/line-grid/line-grid-snap-parsing-expected.txt: Added.
* fast/line-grid/line-grid-snap-parsing.html: Added.
* fast/line-grid/script-tests/line-grid-snap-parsing.js: Added.
* svg/css/getComputedStyle-basic-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Adding methods setGeometry and setFont to QWebSelectMethod class.
https://bugs.webkit.org/show_bug.cgi?id=71530

Reviewed by Simon Hausmann.

Adding methods setGeometry and setFont so that users of platform plugin may show the
popup menus in proper position and using proper font.

* Api/qwebkitplatformplugin.h:
* WebCoreSupport/PopupMenuQt.cpp:
(WebCore::PopupMenuQt::show):
* examples/platformplugin/WebPlugin.h:
(WebPopup::setGeometry):
(WebPopup::setFont):
* examples/platformplugin/qwebkitplatformplugin.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add ARMv7 support to the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=72061

Reviewed by Geoff Garen.

* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):
    - Add CPU(ARM) copies of these functions.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::spill):
    - Fix matching of '}' re #if blocks, makes some tools happy.
(JSC::DFG::JITCodeGenerator::setupArguments):
(JSC::DFG::JITCodeGenerator::setupArgumentsWithExecState):
(JSC::DFG::JITCodeGenerator::appendCallWithExceptionCheckSetResult):
(JSC::DFG::JITCodeGenerator::appendCallSetResult):
    - Add CPU(ARM) / 4 argument register copies of these functions.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
    - Should use callOperation to plant a call to a DFG_OPERATION.
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
    - These methods need to plant a relinkable jump; we currently do so
      using beginUninterruptedSequence() / endUninterruptedSequence().
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
    - Should use callOperation to plant a call to a DFG_OPERATION.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
    - This method needs to plant a relinkable jump; we currently do so
      using beginUninterruptedSequence() / endUninterruptedSequence().
(JSC::DFG::JITCompiler::compileBody):
    - Add abstraction to retrieve the pc after a call.
* dfg/DFGOSRExitCompiler.cpp:
    - Fix a bug - CodeLocationLabel needs a data address rather than an
      executable one, but can just take a MacroAssemblerCodePtr instead!
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::compileClampDoubleToByte):
    - Add FIXME comment to come back to! - bug#72054.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
    - Add missing method (ooops, required by bug#72047)
* dfg/DFGSpeculativeJIT32_64.cpp:
    - Need to wrap fmod on ARMv7.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove effectBoundingBoxMode from CSS Filters https://bugs.webkit.org/show_bug.cgi?id=72058

Reviewed by Simon Fraser.

As suggested by Nikolas, we don't need this virtual method any more.

* rendering/FilterEffectRenderer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
<http://webkit.org/b/72049> Specify testapi.js install path using JAVASCRIPTCORE_FRAMEWORKS_DIR

Reviewed by Joseph Pecoraro.

* JavaScriptCore.xcodeproj/project.pbxproj: The testapi.js
script should use JAVASCRIPTCORE_FRAMEWORKS_DIR in its dstPath
for installation.  Also removed "Versions/A/" from the path
since this is unneeded due the default symlinks present in the
framework.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Lazily start DRT instances in NRWT
https://bugs.webkit.org/show_bug.cgi?id=72038

Reviewed by Eric Seidel.

Just a refactoring, no new tests.

* Scripts/webkitpy/layout_tests/controllers/worker.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
bencher script should support remote benchmarking
https://bugs.webkit.org/show_bug.cgi?id=71618

Rubber-stamped by Geoff Garen.
        
Added the following features:
        
- Benchmark report tells you the hostname and machine model (according to
  'sysctl hw.model') of the machine you did the run on, and svn revision number
  (according to 'svn info') of the VMs you're testing.
        
- The --remote option. You give this an ssh-style hostname (i.e. user@host is
  acceptable, in addition to just host, in which case your username is used)
  and it automatically packages the build directories of the VMs you're testing,
  sends them to the remote machine along with your copy of the bencher script
  and all of the options you passed.  This pretty much seamlessly allows you
  to run a set of benchmarks on any machine that is sufficiently compatible with
  yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
  must now include a tempPath setting that tells bencher where to put files
  when that machine is used as a slave in a remote benchmarking run.
          
- Added yet another way of specifying which benchmarks to run. This was sort of
  necessary for --remote to work as expected. Previously, you either said what
  suites to exclude (for example --exclude-sunspider) or that you only wanted
  to run one suite to the exclusion of others (--sunspider-only). But it's
  often better to just be able to specify the list of suites you want. This is
  now supported. You can say, for example, --v8 --sunspider, which means, just
  run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
  still supported.

* Scripts/bencher:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ValueProfile/PredictedType contains dead code, and doesn't recognize functions
https://bugs.webkit.org/show_bug.cgi?id=72065

Reviewed by Gavin Barraclough and Geoff Garen.
        
Added PredictFunction support, and did some cleaning up along the way.
ValueProfile no longer has statistics machinery, because we never used
it. Rearranged some bits in PredictedType to more easily make room for
one more object type. Changed some debug code to use more consistent
conventions (ByteArray becomes Bytearray so that if we ever have a
"Byte" prediction we don't get confused between a prediction that is
the union of Byte and Array and a prediction that indicates precisely
a ByteArray).

* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionFromClassInfo):
* bytecode/PredictedType.h:
(JSC::isFunctionPrediction):
* bytecode/ValueProfile.cpp:
* bytecode/ValueProfile.h:
(JSC::ValueProfile::dump):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
https://bugs.webkit.org/show_bug.cgi?id=66584
WebKit2's find bouncy looks blurry after dragging window onto >1.0 scale factor 
display
-and corresponding-
<rdar://problem/9987559>

Reviewed by Anders Carlsson.

The setFindIndicator message and various functions of the same name must all take 
an additional parameter indicating whether or not setting the find indicator 
should result in a bounce animation. This is because when the device scale factor 
changes, if there is currently a find indicator, it must be re-set to a higher or 
lower resolution version, but we don't want the bounce animation to happen again.
* UIProcess/API/mac/FindIndicatorWindow.h:
* UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::setFindIndicator):
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/API/mac/WKView.mm:
(-[WKView _setFindIndicator:fadeOut:animate:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFindIndicator):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

New function FindController::isShowingOverlay() is used to determine if 
FindController::deviceScaleFactorDidChange() needs to be called.
* WebProcess/WebPage/FindController.h:
(WebKit::FindController::isShowingOverlay): 

FindController::deviceScaleFactorDidChange() calls updateFindIndicator to re-
generate the bitmap at the appropriate scale factor, but tells it not to animate 
this time.
(WebKit::FindController::deviceScaleFactorDidChange):

updateFindIndicator() takes a new parameter indicating whether or not the 
FindIndicator should animate. It defaults to true since the deviceScaleFactor 
changing is the only case currently where we do not want it to animate.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):

Calls into FindController::deviceScaleFactorDidChange() when the scale factor has 
changed and the find overlay is showing.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Speculative build fix.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::setFindIndicator):
* UIProcess/win/WebView.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix 32-bit build.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(-[WKContentLayer drawInContext:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
More attempted build fix.

* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/API/efl/PageClientImpl.h:
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/API/gtk/PageClientImpl.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Once more for the QT build.

* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::setFindIndicator):
* UIProcess/qt/QtWebPageProxy.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, revert a misplaced expected text in r99819.
A results-expected is platform independent. r99828 fixed this.

* platform/chromium/fast/harness/results-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
DFG byte array support sometimes clamps values incorrectly
https://bugs.webkit.org/show_bug.cgi?id=71975

Source/JavaScriptCore: 

Reviewed by Oliver Hunt.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):

LayoutTests: 

Reviewed by Oliver Hunt.
        
Added a test for byte arrays, and fixed a small bug in dfg-min-max.js.

* fast/js/dfg-byte-array-put-expected.txt: Added.
* fast/js/dfg-byte-array-put.html: Added.
* fast/js/script-tests/dfg-byte-array-put.js: Added.
(doPut):
(doGet):
* fast/js/script-tests/dfg-min-max.js:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ASSERT when outdenting styled line break.
https://bugs.webkit.org/show_bug.cgi?id=72069
<rdar://problem/10429739>

Reviewed by Ryosuke Niwa.

Source/WebCore: 

When outdenting a line break that has some inline style, we don't consider
the enclosing elements that provide the style.
This causes the splitting to occur in the wrong position,
triggering the assert.
         
Test: editing/execCommand/outdent-break-with-style.html

* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::outdentParagraph): The fix consists
in choosing the highest inline ancestor as splitting point.
* editing/htmlediting.cpp:
(WebCore::isInline): Added.
* editing/htmlediting.h: Added isInline.

LayoutTests: 

* editing/execCommand/outdent-break-with-style-expected.txt: Added.
* editing/execCommand/outdent-break-with-style.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
RenderTableSection's recalcCell logic is doing too much work
https://bugs.webkit.org/show_bug.cgi?id=71986

Reviewed by Darin Adler.

No change in behavior expected so no test.

r98738 and r98980 missed the point that Vector::clear() does not touch
the internal buffer. Thus calling clear() would keep the memory and properly
reset the size().

Due to how the code worked, after r98980 the code would end up resetting some
of RowStruct field twice: once when growing and the other one when calling
fillRowsWithDefaultStartingAtPosition.

This change make the code use Vector::clear and simplified the recalcCells
logic knowing that growing the Vector will properly initialize most of the
RowStruct fields (with RowStruct constructor).

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::addCell):
Updated after ensureRows signature change.

(WebCore::RenderTableSection::ensureRows):
Removed the overflow check as it was making some assumption as to how the
Vector worked. If we want to implement a limit, we may do it differently.
Also inlined the part of fillRowsWithDefaultStartingAtPosition that grows
the columns to match our current representation. The rest of the function's
initialization is handled by the constructor already.

(WebCore::RenderTableSection::recalcCells):
Use clear() as it keeps the buffer and just resets the size. Also shrinkToFit
at the end as we may have lost some rows.

* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::CellStruct::CellStruct):
Fixed the style of the constructor.

(WebCore::RenderTableSection::RowStruct::RowStruct):
Added an explicit constructor (which is equivalent to the default one)
but underlines what we expect.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=72001

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r99916.
http://trac.webkit.org/changeset/99916
https://bugs.webkit.org/show_bug.cgi?id=72077

fast/harness/result.html seems platform dependent (Requested
by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-10

* platform/chromium/fast/harness/results-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99922 268f45cc-cd09-0410-ab3c-d52691b4dbfc