params passing now