ah yea right :-(

- tobi
CEO Shopify


On Tue, Jun 3, 2014 at 5:48 PM, Caroline <notifications@github.com> wrote:

> In snippets/footer.liquid:
>
> > -          {% if settings.pinterest_link != blank %}<li class="pinterest"><a href="{{ settings.pinterest_link }}" title="{{ shop.name }} on Pinterest">p</a></li>{% endif %}
> > -          {% if settings.google_plus_link != blank %}<li class="google-plus"><a href="{{ settings.google_plus_link }}" title="{{ shop.name }} on Google+">g</a></li>{% endif %}
> > -          {% if settings.instagram_link != blank %}<li class="instagram"><a href="{{ settings.instagram_link }}" title="{{ shop.name }} on Instagram">i</a></li>{% endif %}
> > -          {% if settings.tumblr_link != blank %}<li class="tumblr"><a href="{{ settings.tumblr_link }}" title="{{ shop.name }} on Tumblr">t</a></li>{% endif %}
> > -          {% if settings.youtube_link != blank %}<li class="youtube"><a href="{{ settings.youtube_link }}" title="{{ shop.name }} on YouTube">y</a></li>{% endif %}
> > -          {% if settings.vimeo_link != blank %}<li class="vimeo"><a href="{{ settings.vimeo_link }}" title="{{ shop.name }} on Vimeo">v</a></li>{% endif %}
> > -          {% if settings.fancy_link != blank %}<li class="fancy"><a href="{{ settings.fancy_link }}" title="{{ shop.name }} on Fancy">F</a></li>{% endif %}
> > +          {% if settings.twitter_link != blank %}
> > +            <li>
> > +              <a class="icon-fallback-text" href="{{ settings.twitter_link }}" title="{{ shop.name }} on Twitter">
> > +                <span class="icon icon-twitter" aria-hidden="true"></span>
> > +                <span class="fallback-text">Twitter</span>
> > +              </a>
> > +            </li>
> > +          {% endif %}
> > +          {% if settings.facebook_link != blank %}
>
> @graygilmore <https://github.com/graygilmore> I prefer != blank.
>
> An empty string will be truthy @Tobi <https://github.com/Tobi>.
>
> [image: Alt text]
> <https://camo.githubusercontent.com/d7dc8078e081dcfdac5f8ecd4574a9bb77a6baba/68747470733a2f2f6d6f6e6f736e61702e636f6d2f696d6167652f79596c337452744230666c433244493641464734594e75616b5a6565776f2e706e67>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Shopify/Timber/pull/85/files#r13361225>.
>