Yeah, I don't think it is, but experiment_activity.rb:7 initializes it to
true.


On Tue, Apr 15, 2014 at 12:35 PM, tobyk100 <notifications@github.com> wrote:

> In test/controllers/activities_controller_test.rb:
>
> > +    end
> > +
> > +    assert_response :success
> > +
> > +    expected_response = {"previous_level"=>"/s/#{@script.id}/level/#{@script_level_prev.id}",
> > +                         "total_lines"=>35,
> > +                         "redirect"=>"/s/#{@script.id}/level/#{@script_level_next.id}",
> > +                         "level_source"=>"http://test.host/sh/#{assigns(:level_source).id}",
> > +                         "save_to_gallery_url"=>"/gallery_activities?gallery_activity%5Bactivity_id%5D=#{assigns(:activity).id}"}
> > +
> > +    assert_equal expected_response, JSON.parse(@response.body)
> > +  end
> > +
> > +  test "logged in milestone not passing" do
> > +    # TODO actually test experiment instead of just stubbing it out
> > +    ExperimentActivity.expects(:is_experimenting_feedback_design?).returns(false)
>
> seems like set_experimenting_feedback_design is never called (I can't
> grep find it).
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/code-dot-org/dashboard/pull/470/files#r11653264>
> .
>