Reverting this change as it caused issues with userVmResponse.  "Findbugs: different issues solved"

This reverts commit dcda79e2c02fda4e0fe52f61bf61712742e1f0db.
LOUDSTACK-5987: when listTemplates with filter=community/featured, get public templates from all domains in the system, not just parent/child subdomains of the caller

Conflicts:
	server/src/com/cloud/api/query/QueryManagerImpl.java
(cherry picked from commit b1d4c06ad1d8931f5c810dcd8b1f1df01db174f3)

Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
CLOUDSTACK-5986: Make dnsmasq handle dnsmasq.leases when dhcp_release is available

The original issue has been exposed due to CloudStack VR would modify the
dnsmasq.leases, thus make it unsync with dnsmasq's memory lease.

Make the modification to let dnsmasq handle the lease file if dhcp_release is
available.
(cherry picked from commit 441d02dd402e632c3eba1062a55fc0d752e76003)

Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
CLOUDSTACK-5966 Update the schema-421-430.sql for EnableServiceMonitoring global setting
(cherry picked from commit 888b90677623da745a01db0a5087272f0dabe42c)

Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
CLOUDSTACK-5966 Updated service monitoring config to start by default.
Global settings EnableServiceMonitoring param set to true
(cherry picked from commit 7255e50f2051aff1cb5e1991e2dde4ef48f57454)

Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
CLOUDSTACK-5660: Migrate vm live migration succeeds but throws error as "Failed to migrate the system vm".
(cherry picked from commit cff312ef743763c69b0c3b0cfd9faf906f3cf22c)

Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
CLOUDSTACK-5989: Trying to start a vm while 'vm snapshot' is in progress results in inconsistency
The fix is to fail the start operation if a vm snapshot is in progress
(cherry picked from commit 775fa0f0d02f182e3cba02faed569272b00e9926)

Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
Revertng based on mail thread discussion  "Fix findbug issues within LDAP authenticator"

This reverts commit 92b4f66d73562e4211d2d787554ff229dbeb5705.
findbugs replaced byte[].toString() with Arrays.toString(byte[])(cherry picked from commit ce7c6d23575d455a8273b77702a56b7bb419b37b)

Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
Fixed API doc that got broken by adding new commands for stratosphere ssp plugin
(cherry picked from commit 54f2234e2191533be21b328534dc20b1871ca3ad)

Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
CLOUDSTACK-5996: UI - In project view, the first listRotuers API(without projectid=-1) will return the same objects as the second listRouters API(with projectid=-1), because in project view, all API calls are appended with projectid=[projectID]. Therefore, we only call the second listRouters API(with projectid=-1) in non-project view.
(cherry picked from commit 713240baef97ddd62b646ad35c86e1e3ab6702d6)

Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
CLOUDSTACK-5994. Hitting IndexOutOfBoundsException in GetVmStatsCommand after upgrade.
To obtain network read/write statistics, multiply sample duration with the
average of the particular performance metric obtained over the sample period.
(cherry picked from commit 16c3f53793517e3c924df5ff6d9dc872dd508731)

Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
CLOUDSTACK-5900: Failed to delete template/ISO that failed to download.
(cherry picked from commit ae22d1990e081267fdb68b2e014153a8207083c5)

Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
CLOUDSTACK-5900: Failed to delete template/ISO that failed to download.
(cherry picked from commit 8024f2cc70c31ab22efe574e866cc9de7a48da28)

Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
findbugs: assign result of string manipulations
(cherry picked from commit 20127e09dc0e341a2f790a8a52cded4c5f1f0cc1)

Signed-off-by: Daan Hoogland <daan@onecht.net>
findbugs get proper object from map
(cherry picked from commit 901cf8ab32e8077e3b64204c89418181fd5ce0b6)

Signed-off-by: Daan Hoogland <daan@onecht.net>
findbugs explicit toString on enum for call get(Object)
(cherry picked from commit cce4a055ae9bdda1e3f5ae2c95efc9dace75814b)

Signed-off-by: Daan Hoogland <daan@onecht.net>
findbugs get from map with proper key-type
(cherry picked from commit a4f2f0b39fadf3510e15c8955a50a3a4a5d7c694)

Signed-off-by: Daan Hoogland <daan@onecht.net>
findbugs Long comparison == -> equals()
(cherry picked from commit f4db8df66fbcb5df3cd9bbf607ede9a4d514fe4a)

Signed-off-by: Daan Hoogland <daan@onecht.net>
Revert "findbugs replaced byte[].toString() with Arrays.toString(byte[])(cherry picked from commit ce7c6d23575d455a8273b77702a56b7bb419b37b)"

This reverts commit 55ec8f3a2d8ae73ae1e20a806a8f8d0ee29fa274.