Looks like I commented on the wrong PR.

My comments were:

- Let's change all references to microseconds since the epoch to
nanoseconds. That's how Go uses an int64 for unix time.

- Should we change the naming convention for protobuf fields to match the
Go naming style? TxId, MaxWallTime, etc. I see that go already does it
internally. Shouldn't we make them match up so there's less confusion?
Perhaps that's still not the right style...?


On Sat, Feb 15, 2014 at 6:48 PM, Shawn Morel <notifications@github.com>wrote:

> In apipb/README.md:
>
> > @@ -0,0 +1,13 @@
> > +# Cockroach Protobuffer API
> > +
> > +This defines the low-level key-value API
> > +
> > +## Hacking
> > +
> > +The Go build tools don't support code generation very well. The approach taken here is to commit the Go generated sources along side the .proto files. This is modeled after https://github.com/golang/groupcache/blob/master/groupcachepb/groupcache.pb.go by @bradfitz
>
> I'm not sure I understand the comment. If we add this as a pre-commit
> hook, you're still checking in the generated files no? The main problem is
> there's no good way to trigger a building of the proto as part of the go
> sources build process. It would suck for each dev to need to compile the
> protos rather than simply "go get"
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/spencerkimball/cockroach/pull/7/files#r9775074>
> .
>