I like the rationale, +1.


2014-03-21 11:42 GMT-06:00 Jai Ram Rideout <notifications@github.com>:

> In skbio/maths/subsample.py:
>
> > @@ -29,18 +30,21 @@
> >  import numpy as np
> >
> >
> > -def subsample(counts, n):
> > -    """Subsample from a vector of counts.
> > +def subsample(counts, n, multinomial=False):
> > +    """Randomly subsample from a vector of counts.
>
> How about subsample(counts, n, replace=False)? This way the name matches
> np.random.choice, and keeps the default behavior as sampling without
> replacement.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/biocore/scikit-bio/pull/206/files#r10846124>
> .
>