Revert "coll/basic: fix segmentation fault in neighborhood collectives if the degree"

This reverts commit 9c788ff9400960823637dc0eebb3a8640414fa05.
coll/basic: fix segmentation fault in neighborhood collectives if the degree
of the topology is higher than the communicator size

It is possible to have a topology degree higher than the size of the communicator.
For example, a periodic cartesian communicator on MPI_COMM_SELF. This will leave
the neighborhood collectives with a request buffer that is too small.

This commits introduces a semantic change :
from now, c_topo must be set before invoking coll_select
* comment on communicator creation in mca_topo_base_dist_graph_create(...)
* use accesors to retrieve topo info
Delete old gni config file

Delete a legacy ompi_check_gni m4 file.  No longer used.
Check for the presence of setenv. If it is present, then use it in opal_setenv when setting values in the environ
OSHMEM: sshmem mmap: removed unused help topics
Update the opal_environ code so it behaves correct with the environ if setenv is not available
Fix stupid typo
btl/openib: send openib modex with the PMIX_GLOBAL flag
Don't release the provided opal_proc in the error path.
Merge branch 'master' of github.com:open-mpi/ompi
This commit contains new dstore component sm which is used for communication between pmix server and clients at the same node via shared memory.
Copy 1.8.4 release NEWS entries
Copy 1.8.4 release NEWS entries
btl/openib: send openib modex with the PMIX_GLOBAL flag
Don't release the provided opal_proc in the error path.
Merge remote-tracking branch 'origin'
Remove invalid NEWS item for 1.8.4
cleanup ugni compiler warnings
fix make dist for pmix/cray

Include file was left out of "sources" list that prevented
building for cray from dist tarball.