Update query bindings only on Settings update

This ensures the Cancel button behaves correctly (i.e. no-op).

Bug # 9935

Signed-off-by: Alex Coles <alex@alexbcoles.com>
Add unit test for SettingsModalController

Signed-off-by: Alex Coles <alex@alexbcoles.com>
Prune unused argument from updateQuery function

See a36f784f

Signed-off-by: Alex Coles <alex@alexbcoles.com>
Merge pull request #1495 from opf/fix/page-settings-cancel-button

Fix page settings cancel button