Fix checkpatch errors carried over from 2.1

2.1 had several checkpatch errors unresolved.

This does not touch FSAL_GLUSTER.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
Remove check for NULL return from alloca in FSAL_VFS and FSAL/commonlib.c

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
Improve debug of FSAL_VFS create_handle

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
Remove unecessary retval test in vfs_get_root_handle (fixes CID24704)

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
call freeaddrinfo in add_client (fixes CID24706)

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
don't overwrite b_left in set_const_log_str (fixes CID24711 and CID24716)

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
Return CACHE_INODE_BAD_TYPE as error in cache_inode_setattr (fixes CID24721)

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
Simplify getting clientid_owner for LAYOUT ops (fixes CID24720)

The LAYOUT ops used to call get_clientid_owner to get the clientid owner
for the clientid associated with the current session. Since the ops MUST
be within a session, and thus the session and it's associated clientid
MUST be valid, we don't need to lookup, we can just look into the
associated clientid for it's owner.

This resolves any reference counting issues, and happens to clear a
Coverity bug with an ignored return result.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Acked-by: Malahal Naineni <malahal@us.ibm.com>
Merge remote-tracking branch 'origin/for-2.2-dev-2' into next

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Merge remote-tracking branch 'phdeniel/pull_request' into next

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Merge remote-tracking branch 'linuxbox2/next-cov' into next

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
V2.2-dev-2

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
16 bit export_id on DBUS:
Expect 16 bit export id on DBUS command.

Signed-off-by: suhrud <supatank@in.ibm.com>
Added support for CLAIM_PREVIOUS

Signed-off-by: Venkateswararao Jujjuri (JV) <jvrao@linux.vnet.ibm.com>
Reviewed-by: Srikrishan Malik <srimalik@in.ibm.com>
Return Not Supported for both nfs4_op_delegpurge and CLAIM_DELEGATE_PREV

Currnt code mostly supports CLAIM_DELEGATE_PREV but there is lot more
needed to fully support it.

Some of the missing pieces are:
1. Fully supporting nfs4_op_delegpurge.
2. making sure that the delegations are not removed/cleaned on
   setclientid sequence.

This is helpful for those clients which uses persistent storage
for data cache, and these delegations are called client-persistent delegations
When there is needed we can address above mentioned issues and enable then.

Signed-off-by: Venkateswararao Jujjuri (JV) <jvrao@linux.vnet.ibm.com>
Reviewed-by: Srikrishan Malik <srimalik@in.ibm.com>
Set the pre-recalled flag for deleg reclaims.

This flag will be set for reclaim opens when for the delegation would not be
granted for non-reclaim opens.

Signed-off-by: Srikrishan Malik <srimalik@in.ibm.com>
Reviewed-by: Malahal Naineni <malahal@us.ibm.com>
Fix for coverity CID24725

The allocated string buffer is not enough to hold the original string
buffer, but we do copy only a partial string.  This is clearly a false
positive from coverity as it doesn't really look at how the string is
used! Use gsh_strdup as this is more cleaner, and as a bonus avoids
this false positive from coverity!

Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
Reviewed-by: Venkateswararao Jujjuri (JV) <jvrao@linux.vnet.ibm.com>
Don't try deleting dot and dotdot entries

Replaced the while statement with for statement that avoided a goto
label altogether as well.

Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
Reviewed-by: Venkateswararao Jujjuri (JV) <jvrao@linux.vnet.ibm.com>
Don't give out delegation on a just recalled file

If a client's open causes recall of existing delegations, we respond to
the client with NFS4ERR_DELAY and recall the delegations asynchronously.
If delegations are recalled and another client were to open the file
before the original client that caused recalls, we should not give out
delegation to the latter client to avoid starving the former. We simply
avoid granting delegations for some time period from the last recall to
avoid this.

Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
Reviewed-by: Venkateswararao Jujjuri (JV) <jvrao@linux.vnet.ibm.com>
Fix granting delegations based on client's behaviour

If a client has more than than couple revokes, we stop giving
delegations to the client.

Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
Reviewed-by: Venkateswararao Jujjuri (JV) <jvrao@linux.vnet.ibm.com>