2011-04-01  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Synchronization between WebCore's ContextMenuItem.h and ewk_contextmenu.h
        https://bugs.webkit.org/show_bug.cgi?id=57000

        * ewk/ewk_contextmenu.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-01  Nancy Piedra  <nancy.piedra@nokia.com>

        Reviewed by Benjamin Poulain.

        [Qt] DragClientQt.h has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40425

        * WebCoreSupport/DragClientQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-01  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: up/down keys are not treating hex numbers properly while editing styles.
        https://bugs.webkit.org/show_bug.cgi?id=40522

        Drive-by: fix inc/dec for numbers like ".5"

        Test: inspector/styles/up-down-numerics-and-colors.html

        WebCore:
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype):

        LayoutTests:
        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.createKeyEvent): Added arguments for key modifiers.
        * inspector/styles/up-down-numerics-and-colors-expected.txt: Added.
        * inspector/styles/up-down-numerics-and-colors.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Split LayerTreeHostCA into a base class and derived Mac and Win classes

This will make it easier to customize the Mac and Windows implementations without adding too
many #ifdefs.

Fixes <http://webkit.org/b/57606> Windows and Mac should use separate LayerTreeHost classes

Reviewed by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj: Added LayerTreeHostCAMac.h.

* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create): Create a LayerTreeHostCAMac on Mac, and LayerTreeHostCAWin
on Windows.

* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::LayerTreeHostCA): Moved some code from here...
(WebKit::LayerTreeHostCA::initialize): ...to here. This function will be called after the
constructor returns, and thus can safely call functions that are pure virtual in this class
and its base class. We now pass our LayerTreeContext to platformInitialize so that our
derived classes can initialize it.
(WebKit::LayerTreeHostCA::~LayerTreeHostCA): Removed Mac-specific code.

(WebKit::LayerTreeHostCA::invalidate):
(WebKit::LayerTreeHostCA::sizeDidChange):
(WebKit::LayerTreeHostCA::forceRepaint):
(WebKit::LayerTreeHostCA::didPerformScheduledLayerFlush):
Removed platform* calls. Derived classes can just override these functions to do what they
need.

* WebProcess/WebPage/ca/LayerTreeHostCA.h: Removed Mac-specific pieces. Made some functions
virtual so that derived classes can override them.

* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h: Added.

* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::create): Create and initialize a host.
(WebKit::LayerTreeHostCAMac::LayerTreeHostCAMac): Simple constructor.
(WebKit::LayerTreeHostCAMac::~LayerTreeHostCAMac): Moved code here from LayerTreeHostCA
destructor.
(WebKit::LayerTreeHostCAMac::platformInitialize): Removed direct uses of LayerTreeHostCA
data members.

(WebKit::LayerTreeHostCAMac::invalidate):
(WebKit::LayerTreeHostCAMac::sizeDidChange):
(WebKit::LayerTreeHostCAMac::forceRepaint):
(WebKit::LayerTreeHostCAMac::didPerformScheduledLayerFlush):
Renamed from platform*. Now call up to the base class.

(WebKit::LayerTreeHostCAMac::flushPendingLayerChangesRunLoopObserverCallback): Updated type.

* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::create): Create and initialize a host.

(WebKit::LayerTreeHostCAWin::LayerTreeHostCAWin):
(WebKit::LayerTreeHostCAWin::~LayerTreeHostCAWin):
(WebKit::LayerTreeHostCAWin::platformInitialize):
(WebKit::LayerTreeHostCAWin::scheduleLayerFlush):
Stubbed out.

* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added.

* win/WebKit2.vcproj: Added LayerTreeHostCAWin.h

* win/WebKit2Apple.vsprops: Added WebProcess/WebPage/ca/win to the include path.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-01  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by Benjamin Poulain.

        Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into
        Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords.

        Tiled painting still causes synchronous layout when
        accelerated compositing and texture mapper are enabled
        https://bugs.webkit.org/show_bug.cgi?id=56929

        * Api/qwebframe.cpp:
        (QWebFramePrivate::renderFromTiledBackingStore):
        (QWebFramePrivate::renderRelativeCoords):
        (QWebFramePrivate::renderFrameWidgets):
        * Api/qwebframe_p.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Cairo build fix

* WebProcess/WebPage/LayerTreeHost.cpp: Only pull in the LayerTreeHostCA derived classes for
PLATFORM(CA) ports.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-01  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: checkboxes are broken in xhr breakpoints sidebar pane.
        https://bugs.webkit.org/show_bug.cgi?id=57610

        * inspector/debugger/xhr-breakpoints-expected.txt:
        * inspector/debugger/xhr-breakpoints.html:
2011-04-01  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: checkboxes are broken in xhr breakpoints sidebar pane.
        https://bugs.webkit.org/show_bug.cgi?id=57610

        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Mark .vcproj/.vsprops/.sln files as being Windows-only

Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have

Reviewed by Anders Carlsson.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
directories as Windows-only.

* Scripts/webkitpy/common/config/build_unittest.py:
(ShoulBuildTest): Added test cases for the above.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-01  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: event should have "data" attribute, not "body"
        https://bugs.webkit.org/show_bug.cgi?id=57628

        * inspector/protocol/console-agent-expected.txt:
2011-04-01  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: event should have "data" attribute, not "body"
        https://bugs.webkit.org/show_bug.cgi?id=57628

        * inspector/CodeGeneratorInspector.pm:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs

Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting

Reviewed by Darin Adler.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
URL on its own line.

* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
progression, and added a new test that uses a short bug URL while I was at it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Retrieve revision numbers from the build's got_revision property in Leaks Viewer

Previously, we were getting the revision of the first revision that triggered a build.
Choosing the last revision would have been more accurate. But got_revision is what is used
everywhere else on build.webkit.org, and should work even when there were no changes that
triggered a build (e.g., if someone clicked the Force Build button).

Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
recent builds list

Reviewed by Anders Carlsson.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
property, rather than out of the first (i.e., earliest) change in the sourceStamp object.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
(Array.prototype.first): Added this helper function to return the first element in an array
that matches the given predicate, or null if no such element exists.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-01  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make editScriptSource a Script's method.
        https://bugs.webkit.org/show_bug.cgi?id=57615

        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.editScriptSource):
        (WebInspector.DebuggerModel.prototype._didEditScriptSource):
        * inspector/front-end/Script.js:
        (WebInspector.Script.prototype.requestSource):
        (WebInspector.Script.prototype.editSource):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Disable inspector/debugger/debug-inlined-scripts.html

It is flaky. The flakiness is tracked by <http://webkit.org/b/56584>.

* inspector/debugger/debug-inlined-scripts.html-disabled: Renamed from LayoutTests/inspector/debugger/debug-inlined-scripts.html.

* platform/mac-wk2/Skipped: Removed the now-disabled test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-03-23  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: fix reveal line in formatted script.
        https://bugs.webkit.org/show_bug.cgi?id=56941

        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.JavaScriptBreakpointsSidebarPane):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.sourceFileForScriptURL):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
        (WebInspector.NetworkPanel.prototype.showAnchorLocation):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.canShowAnchorLocation):
        (WebInspector.Panel.prototype.showAnchorLocation):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.canShowAnchorLocation):
        (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
        (WebInspector.ResourcesPanel.prototype.showResource):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
        (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
        (WebInspector.ScriptsPanel.prototype._showSourceLine):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.highlightLine):
        (WebInspector.SourceFrame.prototype._createTextViewer):
        * inspector/front-end/inspector.js:
        (WebInspector.documentClick.followLink):
        (WebInspector.documentClick):
        (WebInspector._showAnchorLocation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-01  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        Reviewed by Dimitri Glazkov.

        <meter> can only support horizontal indicator
        https://bugs.webkit.org/show_bug.cgi?id=56001

        - Simpflied some test cases which had vertical indicators.
        - Updated expectations due to shadow structure change
        - Skipped tetsts which need expectations update.

        * fast/dom/HTMLMeterElement/meter-element.html:
        * fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html:
        * fast/dom/HTMLMeterElement/meter-styles.html:
        * platform/gtk/Skipped:
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-04-01  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        <meter> can only support horizontal indicator
        https://bugs.webkit.org/show_bug.cgi?id=56001

        - Removed code which deals with the direction and
          left the horizontal path.
        - Removed "horizontal" from related names which is now
          redundant.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId):
        (WebCore::nameToPseudoTypeMap):
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        * css/html.css:
        (meter::-webkit-meter-bar):
        (meter::-webkit-meter-optimum-value):
        (meter::-webkit-meter-suboptimal-value):
        (meter::-webkit-meter-even-less-good-value):
        * rendering/RenderMeter.cpp:
        (WebCore::RenderMeter::~RenderMeter):
        (WebCore::RenderMeter::createPart):
        (WebCore::RenderMeter::updateFromElement):
        (WebCore::RenderMeter::layoutParts):
        (WebCore::RenderMeter::styleDidChange):
        (WebCore::RenderMeter::shouldHaveParts):
        (WebCore::RenderMeter::valuePartRect):
        (WebCore::RenderMeter::valuePseudoId):
        (WebCore::RenderMeter::barPseudoId):
        (WebCore::RenderMeter::detachShadows):
        (WebCore::RenderMeter::updateShadows):
        * rendering/RenderMeter.h:
        (WebCore::RenderMeter::shadowAttached):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::supportsMeter):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMeter):
        (WebCore::RenderThemeMac::supportsMeter):
        * rendering/style/RenderStyleConstants.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-01  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        ARIA Grid tables should return GridRole in roleValue() method
        https://bugs.webkit.org/show_bug.cgi?id=57614

        This change does not need any test since it doesn't change anything
        from the point of view of the consumers (Assistive Technoglogies).
        It's just an internal change to simplify identifying HTML and ARIA
        tables by calling to the AccessibilityObject::roleValue method.

        * accessibility/AccessibilityARIAGrid.h:
        * accessibility/AccessibilityARIAGrid.cpp:
        (WebCore::AccessibilityARIAGrid::roleValue): Return GridRole.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (atkRole): Removed unneeded comment.

        * accessibility/mac/AccessibilityObjectWrapper.mm: Map GridRole to
        NSAccessibilityTableRole, to keep the same behaviour.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-03-31  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        [chromium] update the rebaseline tool to know about pngs with checksums
        https://bugs.webkit.org/show_bug.cgi?id=57481

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-01  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Nikolas Zimmermann.

        https://bugs.webkit.org/show_bug.cgi?id=55750
        SVG <image> referenced by <use> is displayed incorrectly

        Reintroduce old behaviour for valid base URI, for invalid
        keep using document base URI.
        Fixes regression of W3C-SVG-1.1/struct-image-07-t.svg.

        Test: svg/custom/image-base-uri.svg

        * svg/SVGImageLoader.cpp:
        (WebCore::SVGImageLoader::sourceURI):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-03-31  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Andreas Kling.

        Whenever a relayout is trigger for SVGPath, make sure
        to clear its previous marker layout info. This helps
        to prevent removed markers from being used.
        https://bugs.webkit.org/show_bug.cgi?id=57492

        Test: svg/dom/path-marker-removed-crash.svg

        * rendering/svg/RenderSVGPath.cpp:
        (WebCore::RenderSVGPath::layout):
        * rendering/svg/SVGMarkerLayoutInfo.cpp:
        (WebCore::SVGMarkerLayoutInfo::clear):
        * rendering/svg/SVGMarkerLayoutInfo.h:
2011-03-31  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Andreas Kling.

        Tests that we do not crash when trying to paint a removed
        svg marker element.
        https://bugs.webkit.org/show_bug.cgi?id=57492

        * svg/dom/path-marker-removed-crash-expected.txt: Added.
        * svg/dom/path-marker-removed-crash.svg: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2011-04-01  MORITA Hajime  <morrita@google.com>

        Unreviewed expectation/skip update that follows r82686.

        - Updated expectataions for gtk port.
        - Skipped some win tests whose expectations are need to be updated but
          the result isn't available from build.webit.org.

        * platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
        * platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
        * platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82691 268f45cc-cd09-0410-ab3c-d52691b4dbfc