Hi everyone, Giulio, Fererico,
Here the message I recived yesterday and my replies to it.

Nancy
______________________________________

Nancy Marinelli

Research Associate Professor
University of Notre Dame, IN, US

CERN, Bdg 40/3-A01, 1211 Geneva,

SWITZERLAND

Phone +41-22-76-70809, fax +41-22-76-78940

From: Nancy Marinelli <nancy.marinelli@cern.ch<mailto:nancy.marinelli@cern.ch>>
Date: Tue, 4 Mar 2014 18:07:49 +0100
To: cms-sw/cmssw <reply@reply.github.com<mailto:reply@reply.github.com>>, cms-sw/cmssw <cmssw@noreply.github.com<mailto:cmssw@noreply.github.com>>
Cc: Lindsey Gray <Lindsey.Gray@cern.ch<mailto:Lindsey.Gray@cern.ch>>
Subject: Re: [cmssw] Egm ged dqm offline updates for7 xx 1 (#2636)

Hello everyone,
I just pushed to the branch egmGedDQMOfflineUpdatesFor7XX_1 the fix already proposed by Andrea.
This fixes runing the DQM sequence on std photons.

I have run the test on HI and seen that all warnings Andrea was talking about come from the fact that the reco sequence included in the HI includes the ged photons. But for those I pass the ball to Lindsey (in CC)  since the pf clustering and everything is not yet included in the HI sequence.

With the fix I just submitted, in any case, the crash reported by Andrea should be fixed.
Best,
 Nancy
______________________________________

Nancy Marinelli

Research Associate Professor
University of Notre Dame, IN, US

CERN, Bdg 40/3-A01, 1211 Geneva,

SWITZERLAND

Phone +41-22-76-70809, fax +41-22-76-78940

From: perrotta <notifications@github.com<mailto:notifications@github.com>>
Reply-To: cms-sw/cmssw <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Tue, 4 Mar 2014 06:16:24 -0800
To: cms-sw/cmssw <cmssw@noreply.github.com<mailto:cmssw@noreply.github.com>>
Cc: Nancy Marinelli <nancy.marinelli@cern.ch<mailto:nancy.marinelli@cern.ch>>
Subject: Re: [cmssw] Egm ged dqm offline updates for7 xx 1 (#2636)


In DQMOffline/EGamma/python/egammaDQMOffline_cff.py:

>  photonAnalysis.OutputMEsInRootFile = cms.bool(False)
>  photonAnalysis.Verbosity = cms.untracked.int32(0)
>  photonAnalysis.standAlone = cms.bool(False)
>
> +
> +stdPhotonAnalysis = DQMOffline.EGamma.photonAnalyzer_cfi.photonAnalysis.clone()
> +stdPhotonAnalysis.ComponentName = cms.string('stdPhotonAnalysis')
> +stdPhotonAnalysis.analyzerName = cms.string('stdPhotonAnalyzer')
> +stdPhotonAnalysis.photonProducer = cms.string('photons')


HI @nancymarinelli<https://github.com/nancymarinelli>
(@Martin-Grunewald<https://github.com/Martin-Grunewald> can also be interested, as he is going to run the same kind of HLT tests...)

This line is wrong, as the name of the parameter in photonAnalyzer is "phoProducer" and not "photonProducer".
This made some of (independent) HLT tests of mine crash.

At the same time, I realized that this whole PR will also break the DQM sequence for Heavy Ions, again by noticing our HLT HI tests that crashed.

I have prepared a minimal fix for it in
https://github.com/perrotta/cmssw/tree/fixDQMPhotons
(one single commit, two files).

With that fix I get no crashes any more in my tests. However, I have the impression that the HI DQM sequence is still badly performing (just by looking a the warnings I get when running it), and some further adjustment should be probably allowed for it.

If you agree with it, could you please send a pull request with my minimal fix (at least: in order to avoid tests crashing), or with some more complete additional fix of the HI sequence?

Thank you,
Andrea

—
Reply to this email directly or view it on GitHub<https://github.com/cms-sw/cmssw/pull/2636/files#r10255338>.