Add Storwize/SVC configuration attributes

Change-Id: Ica5513abdc8bed298edb475f0c44e2eabf50b93b
explicitly set rpc_backend in cinder.conf

Implements: blueprint centos-rhel-for-block
Fixes: bug #1269432

The following is a default value in cinder:

rpc_backend=cinder.openstack.common.rpc.impl_kombu

Using RDO (rhel/centos) packages, this gets overridden in
/usr/share/nova/cinder-dist.conf to 'impl_qpid'.

In order to cleanly set this back to the default value (which is what we
want as a default in the cookbooks), we need to explicitly set this in
cinder.conf

Change-Id: I5bd0c6ed95a6d02202b19708f15a58ec43a2fe6c
Move to use "get_password" instead of "{user,service,db}_password"

The user_password, service_password and db_password functions are redundant
since they simply call "secret". Creates a get_password function that will
accept a "type" of db, service or user.

All instances of these calls have been changed to call get_password

Change-Id: Ifdb5c7b3f590431aaa7ffc021cdee34899ac8c15
Partial-Bug: #1195915
Merge "Add Storwize/SVC configuration attributes"
change default cinder.volume.driver

Fixes: bug #1269438

New lvm iscsi driver path is:

cinder.volume.drivers.lvm.LVMISCSIDriver

Change-Id: I3427e80c78ec52a6b02cd42d25f425e03e15f01f
Need create init.d script file before enable the service

Closes-bug: #1267095

Change-Id: I7897c6cb03ae3040a819dc86f45fc6c7dea9a3e5
Add name template attributes

Change-Id: I861451d137c2436ae8bb792570751d1ddb754906
Merge "Move to use "get_password" instead of "{user,service,db}_password""
Merge "change default cinder.volume.driver"
Merge "Add name template attributes"
explicitly set volumes_dir in cinder.conf

Fixes: bug #1269475
Implements: blueprint centos-rhel-for-block

On rhel systems, /usr/share/cinder/cinder-dist.conf sets:

volumes_dir=/etc/cinder/volumes

In order set this back to the default cleanly, we need to explicitly set it in
cinder.conf which will take precedence over the setting in
cinder-dist.conf

Change-Id: Id71efd10b0cbd27b72dfe8ec72c51cde70593b3e
Unified Rubocop cleanups under single file.

Consolidate all the .rubocop.yml into a single file, finished out cleanups for
all the Ruby files.

Change-Id: I92d5983724d5d0185cd25bea6a0f46657a6c05d4
Addresses: blueprint rubocop-for-block-storage
Remove Berksfile.lock from dev branches

blueprint remove-berksfile-lock-from-dev-branches

Change-Id: I020ca5189c3b038f0a48aab2ec35ebc00c362214
Remove ambiguity in stubbed methods in spec_helper

- Adjust the stubs in spec/spec_helper.rb to specify the appropriate
  number of expected variables
- Add parenthensis around return values

Change-Id: Id92fbfad0433fcdcbe0ab6909a0b717d614ac62c
Partial-Bug: #1271535
Clean up cookbook for bp/clean-up-attr-for-mq-and-db

This change removes the attributes we'll be moving to openstack-common
and changes reference of those attributes to reflect new (more
consistent) namespace. We also fix a broken test which doesn't properly
converge after changing a node attribute.  Lastly, we handle the rabbit
mq attribute use_ssl.

Change-Id: I12b9c33f89eb35a66bae7420340aff10efd18b1c
Implements: blueprint clean-up-attr-for-mq-and-db