move hard coded values into attribute