commiting assignment solution