Initial Harman HiQnet dissector

Change-Id: I43042edde09395e328d84bf4b172465829915a98
Reviewed-on: https://code.wireshark.org/review/5014
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Hiqnet: fix typo lenght => length

Change-Id: I104d8bb0c56899faef6f4d608859e7b1a34e45a4
Reviewed-on: https://code.wireshark.org/review/5238
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Hiqnet: fix Mac OS X buildbot

Change-Id: Ia4fec86ed389ccb558fe9e1acfb6e87b7012bb75
warning: declaration of 'strlen' shadows a global declaration
Reviewed-on: https://code.wireshark.org/review/5237
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Hiqnet: fix warning found by fix-encoding-args tools

Change-Id: I7e513ec5b617217cd238861f5f02d44edce0bedd
Reviewed-on: https://code.wireshark.org/review/5239
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Add tools for fix -Wdocumentation

Use pragma to disable -Wdocumentation when include glib.h, gmodule or gtk/gtk.h

Change-Id: I576c0d5c4a12ac3b505ac9543646356ff29ac814
Reviewed-on: https://code.wireshark.org/review/5198
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
hiqnet: Use correct filter names; Fix specification of hf_dhcp

   "foo.flags..." --> "hiqnet.flags...";
   Use BASE_NONE for hf_dchp.

Change-Id: Ic3ca4754a1daeefc831dbfcd6a280fe19f8efbf3
Reviewed-on: https://code.wireshark.org/review/5240
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tools: Add fix_pragma_wdocumentation to UNKNOWN licence

Change-Id: Ib5665924b99644c52c95d408c7cff19509cf3eb2
Reviewed-on: https://code.wireshark.org/review/5241
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
[Radius] Make dictionary.starent.vsa1 the default dictionary.
at least with the trace in Bug 10688 that makes the most sense.

Change-Id: I76213449076a2f49a4b72c6dd87b022fb10b9eef
Reviewed-on: https://code.wireshark.org/review/5242
Reviewed-by: Anders Broman <a.broman58@gmail.com>
[GTP] Fix decoding of UMTS GTP QoS Profile i n Radius and Diameter
messages.
Fixes Bug 10688

Change-Id: Iff29ae3f6cee1b4ad12a0e5c5d7fd3da1c9343af
Reviewed-on: https://code.wireshark.org/review/5244
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fix a couple of (AFAICS false) may-be-used-uninitialized warnings that show up with gcc 4.8.3.

Change-Id: I71c9013670dd6e8c74e039bd252cfac2c9e95a18
Reviewed-on: https://code.wireshark.org/review/5246
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Fix a couple of (AFAICS false) may-be-used-uninitialized warnings that show up
on the OSX 10.5 buildbot.

Change-Id: I49e066feab8b980ea85371095234e96e89db71e1
Reviewed-on: https://code.wireshark.org/review/5247
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Fix SMPP timestamp decoding when the current date/time's offset to UTC is
different from the timestamp's offset to UTC.

The fix for bug 6712 ignored the fact that daylight savings will affect the
offset from UTC--and whether daylight savings is in effect today might be
different than whether it was in effect in the timestamp we're decoding.

Bug: 10672
Change-Id: Ie513c361cff41007f2328cd9ca9ca4800ffef500
Reviewed-on: https://code.wireshark.org/review/5245
Petri-Dish: Michael Mann <mmann78@netscape.net>
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
PIM: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I1540c7878692625a9e38b48f8681c07bab852a64
Reviewed-on: https://code.wireshark.org/review/5234
Reviewed-by: Michael Mann <mmann78@netscape.net>
Updates in it translation.

Change-Id: I9e90fca521f17f4ae49e132990f77b2610807e6d
Reviewed-on: https://code.wireshark.org/review/5248
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
ADB: fix  warning: no newline at end of file [-Wnewline-eof]

Warning found by Clang

Change-Id: I7b801808aefa294e32fff560ea1a49620f0e0ea0
Reviewed-on: https://code.wireshark.org/review/5249
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michal Orynicz <michal.orynicz@tieto.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
[Art-Net]
- The heuristic chek was missing "e" out of "Art-Net\0"
- tvb_length() - tvb_captured_length()

Change-Id: Iad9900f3a22e2fdbd0d6056efc1af90511cc458a
Reviewed-on: https://code.wireshark.org/review/5257
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Fix warning: no previous prototype for function ... [-Wmissing-prototypes]

warning coming after g055e4768ece and g421913b721

Change-Id: I5caeeb89c559faef8007f2946c68c7172b75dfa8
Reviewed-on: https://code.wireshark.org/review/5250
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Add Decode As functionality for MPLS PW Associated Channel Type.

Add CFM and MPLS dissector as possible decoders.

Bug: 10574
Change-Id: Ic39c6b8d68b965ff9d342f5ee789a8eff3134a5a
Reviewed-on: https://code.wireshark.org/review/4935
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Qt: Flatten group boxes.

As discussed in change 5185, the "big 3" HIGs discourage the use of
traditional group boxes. Flatten our existing ones.

Change-Id: I68ef4aa9fd0f69a42750bf735df2250a468bfb2d
Reviewed-on: https://code.wireshark.org/review/5263
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Squelch a compiler warning.

Some compilers complain that we're casting a 16-bit integer to a
pointer; making it a standard-size integer squelches the warning.

Change-Id: Iba0e767d7801afdc369b64a1cf050bf8db37da7b
Reviewed-on: https://code.wireshark.org/review/5264
Reviewed-by: Guy Harris <guy@alum.mit.edu>