up views ,refactor