OK. I just wanted you to know I knew it wasn't yet ideal. I'll take another
look since I have to fix the builds anyway.


On Wed, Mar 19, 2014 at 4:19 PM, simoneb <notifications@github.com> wrote:

> In src/nunit.engine/Services/DriverFactory.cs:
>
> > @@ -33,7 +34,22 @@ public class DriverFactory : IDriverFactory, IService
> >
> >          public IFrameworkDriver GetDriver(AppDomain domain, string assemblyPath, IDictionary<string, object> settings)
> >          {
> > -            return new NUnitFrameworkDriver(domain, assemblyPath, settings);
> > +            // Throws if this isn't a managed assembly or if it was built
> > +            // with a later version of the same assembly.
> > +            AssemblyName assemblyName = AssemblyName.GetAssemblyName(assemblyPath);
> > +
> > +            var testAssembly = Assembly.Load(assemblyName);
> > +
> > +            foreach(var refAssembly in testAssembly.GetReferencedAssemblies())
> > +                switch (refAssembly.Name)
> > +                {
> > +                    case "nunit.framework":
>
> I didn't mean to trigger such a philosophical discussion :) I just
> commented on a matter of style and removal of duplication (because those
> two magic strings are in the driver implementations already), but I don't
> mind if they keep being there.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/nunit/nunit-console/pull/19/files#r10776673>
> .
>