I debated with myself abort factoring to a .cc, but the whole header really
isn't much code and it is nice to have the simplicity of header-only. It
also has no other Orly dependencies so it should be easy to take. But it
does require C++ 14.
On May 17, 2014 10:39 PM, "Cody Maloney" <notifications@github.com> wrote:

> In base/json.h:
>
> > +       characters in a string. */
> > +    size_t GetSize() const noexcept {
> > +      assert(this);
> > +      switch (Kind) {
> > +        case Array:  { return Array_ .size(); }
> > +        case Object: { return Object_.size(); }
> > +        case String: { return String_.size(); }
> > +        default: {
> > +          assert(false);
> > +          return 0;
> > +        }
> > +      }
> > +    }
> > +
> > +    /* Parse from the stream. */
> > +    void Read(std::istream &strm) {
>
> It would be nice if this function was in the CC / it's fairly long. I get
> the push for all one header though
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/orlyatomics/orly/pull/65/files#r12772270>
> .
>