Got it .. I'll make the changes.


On Mon, Mar 24, 2014 at 11:18 AM, Michael Meisinger <
notifications@github.com> wrote:

> In ion/services/sa/product/data_product_management_service.py:
>
> > +        # Build query structure for fetching events for the data products passed
> > +        try:
> > +            dqb = DatastoreQueryBuilder(datastore=DataStore.DS_EVENTS, profile=DataStore.DS_PROFILE.EVENTS)
> > +
> > +            filter_origins = dqb.in_(DQ.EA_ORIGIN, *data_product_id_list)
> > +            filter_types = dqb.in_(DQ.ATT_TYPE, "ResourceModifiedEvent")
> > +            filter_mindate = dqb.gte(DQ.RA_TS_CREATED, since_timestamp)
> > +            where = dqb.and_(filter_origins, filter_types, filter_mindate)
> > +
> > +            order_by = dqb.order_by([["ts_created", "desc"]])  # Descending order by time
> > +            dqb.build_query(where=where, order_by=order_by, limit=10, skip=0, id_only=False)
> > +            query = dqb.get_query()
> > +
> > +            event_objs = self.container.event_repository.event_store.find_by_query(query)
> > +
> > +        except:
>
> Please no unqualified excepts. If necessary use except Exception
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/ooici/coi-services/pull/1951/files#r10898028>
> .
>