logic would need some parameters