15. [done, need review]
If you select a coffee break, and go back and forth repeatedly between “Continue” and “Go Back and Make Changes”, then at the second time, the coffee break will appear as taken, although there is no credit card nor cheque payment done. Regression Issue: Seems to be caused by the following check in: “Client feedback (8) is still there, should be done. -- HQ done”, and the checkin revision #4aac947. My tentative fix is as following. Need review.
Change:
//$selectStmt = "select sid from $tablesponsor where sponcode = 'CBMA' and reg_status = ''";
To:
$selectStmt = "select sid from $tablesponsor where sponcode = 'CBMA' and reg_status = '' and (`totaldue`=0 or paytype='MAIL')";