Provided config to have camus fail if it sees any errors

In this case, new ExceptionWriable(value) would be good enough to achieve the object copying.  The next line 'exceptoinWritable.set(value.toString()) is redundant.

________________________________
From: Bryan Baugher [notifications@github.com]
Sent: Thursday, September 04, 2014 8:13 PM
To: linkedin/camus
Cc: Henry Cai
Subject: Re: [camus] Provided config to have camus fail if it sees any errors (#109)


In camus-etl-kafka/src/main/java/com/linkedin/camus/etl/kafka/CamusJob.java:

> @@ -373,11 +386,14 @@ public void printErrors(FileSystem fs, Path newExecutionOutput)
>                       ExceptionWritable value = new ExceptionWritable();
>
>                       while (reader.next(key, value)) {
> -                             System.err.println(key.toString());
> -                             System.err.println(value.toString());
> +                ExceptionWritable exceptionWritable = new ExceptionWritable();


ExceptionWritable doesn't have a constructor that takes in itself. Its just a Text object behind the scenes which sets the string value. Would you want to add that constructor which would basically do super(exceptionWritable.toString())?

—
Reply to this email directly or view it on GitHub<https://github.com/linkedin/camus/pull/109/files#r17155327>.