Clean up SVGPatternElement::collectPatternAttributes
https://bugs.webkit.org/show_bug.cgi?id=127612

Reviewed by Andreas Kling.

This patch refactors SVGPatternElement::collectPatternAttributes() by extracting
the setPatternAttributes logic into a new function. This patch also changes the
while loop to be easier to understand and similar to collectGradientAttributes.

* svg/SVGPatternElement.cpp:
(WebCore::setPatternAttributes):
(WebCore::SVGPatternElement::collectPatternAttributes):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add FALLTHROUGH and -Wimplicit-fallthrough to warn about unannotated implicit fallthroughs in switches
https://bugs.webkit.org/show_bug.cgi?id=127637

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-25
Reviewed by Darin Adler.

For information about [[clang::fallthrough]], see:
<http://clang.llvm.org/docs/LanguageExtensions.html#the-clang-fallthrough-attribute>

* Configurations/Base.xcconfig:
Enable -Wimplicit-fallthrough warnings.

* wtf/Compiler.h:
Define FALLTHROUGH on clang and fallback to outputing nothing when unsupported.

* wtf/dtoa/fast-dtoa.cc:
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::convertLatin1ToUTF8):
(WTF::Unicode::convertUTF16ToUTF8):
(WTF::Unicode::isLegalUTF8):
(WTF::Unicode::readUTF8Sequence):
Explicitly annotate implicit fallthroughs with FALLTHROUGH.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove FIXME in CSSKeywordCompletions.js about "inherit" keyword
https://bugs.webkit.org/show_bug.cgi?id=127638

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-25
Reviewed by Timothy Hatcher.

* UserInterface/CSSKeywordCompletions.js:
(WebInspector.CSSKeywordCompletions.forProperty):
Replace FIXME with a descriptive comment about why the code is what it is.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162794 268f45cc-cd09-0410-ab3c-d52691b4dbfc