CA-141502: Missing 'type' argument in uuid_invalid handled
Signed-off-by: Ravi Pandey <ravi.pandey@citrix.com>
CA-141502: Log warning when messages get GC'ed
Signed-off-by: Ravi Pandey <ravi.pandey@citrix.com>
CA-133523: Revert patch as now -priv is supported again
Merge commit 'e6ab9f7951f55ef1fd24436b0ff46bd8f2e842a8'
CA-140402: set max-idle to 5000ms on OVS

Max-idle is an OVS setting that determines the idle timeout of flows in the
kernel.  Upstream OVS had reduced the timeout from 5000ms to 1500ms, causing
kernel flows to be removed sooner. For flows that send packets with an interval
that is a little larger than 1500ms, this means that every packet will result
in an upcall to the OVS userspace. Tests have shown a relatively large impact
on the dom0 CPU usage due to the reduced timeout.

This patch puts the max-idle timeout back to 5000ms. Do this in xcp-networkd
when it starts up.

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
CA-141474: Don't retry migrate if VM didn't acknowledge shutdown

Signed-off-by: Euan Harris <euan.harris@citrix.com>
CA-141364: Remove wasted hypercalls on domain build

The HPET and VPT are enabled or otherwise within Xenguest. Doing so here is
unnecessary.

Signed-off-by: Si Beaumont <simon.beaumont@citrix.com>
CA-141364: Don't ignore errors from libxc on domain build

Failures from these calls are fatal and we should not continue with any VM
build (start, resume) operations if these calls return an error.

Signed-off-by: Si Beaumont <simon.beaumont@citrix.com>
Merge pull request #1878 from simonjbeaumont/ca-141364-xs64bit

[xs64bit] CA-141364: Handle errors during domain build
Merge pull request #1877 from euanh/CA141474

CA-141474: Don't retry migrate if VM didn't acknowledge shutdown
Merge pull request #1876 from robhoes/maxidle

CA-140402: set max-idle to 5000ms on OVS
CP-9229: Use new path for convert-legacy-stream

The previous path (.../legacy.py) was a symlink for backwards compatibility
with development and we would like to remove it before release.

Signed-off-by: Si Beaumont <simon.beaumont@citrix.com>
Merge pull request #1880 from simonjbeaumont/cp-9229-xs64bit

[xs64bit] CP-9229: Use new path for convert-legacy-stream
Merge commit '9b93ce597b1a4ec10b4d0ccdb6236d12e8efad93'
CP-9366: Use HVM feature-flags instead of checking PV drivers.

Changes:
* xapi_vm_lifecycle check_operation_error uses the flags to check
  whether we can perform a given operation.
* In xapi_host.ml the pre-evacuation check no longer checks for PV
  drivers to learn whether a VM can be migrated.  It was already
  calling Xapi_vm_lifecycle.check_operation_error.
* Appropriate errors are defined: one for each of three features.
* Datamodel refers to a new error instead of vm_missing_pv_drivers.

Related work not done:
* Datamodel has some operations that should mention the new errors.
  They should have mentioned vm_missing_pv_drivers in the past, so
  even now we are no worse off than before.

Signed-off-by: Thomas Sanders <thomas.sanders@citrix.com>
CA-140684: Handle cancellation of VM migration properly

Suggested-by: Yunlei Ding <yunlei.ding@citrix.com>
Signed-off-by: Euan Harris <euan.harris@citrix.com>
CP-9366: Watch the "control" xenstore node, and update VM-metrics "other".

Now when qemu writes a feature-flag into the control node, xapi will
notice and so will trigger the existing code that can copy those entries
into the "other" vm guest metrics parameter.

To make that work, when checking whether the guest metrics should really
be updated, now we go ahead even if only the "other" map has changed.

Signed-off-by: Thomas Sanders <thomas.sanders@citrix.com>
CP-9366: Allow vCPU hotplug for HVM (if feature-vcpu-hotplug is set).

Removed code that raises an Unimplemented exception unconditionally
for hvm guests when attempting vCPU hotplug.
This allows the existing code that decides based on the feature-flag
to work properly.

Signed-off-by: Thomas Sanders <thomas.sanders@citrix.com>
CA-142107: Enable verbose logging for convert-legacy-stream

Signed-off-by: Si Beaumont <simon.beaumont@citrix.com>
CA-142107: Log arguments before spawning convert-legacy-stream

Signed-off-by: Si Beaumont <simon.beaumont@citrix.com>