Add unit test to enforce unique file names.

This patch adds a unit test to ensure we have uniquely named
files across each of the element/target directories. Because
DIB copies these files into a common namespace files can
by cryptically overwritten thus causing a variety of failures.

Simply checking for uniquely named files when running unit
tests should help eliminate future issues here.

Change-Id: Ic22f9eb5e002a0cfe94942e7210eb73231560e82
Partial-bug: #1321849
Add heat support to os-collect-config.conf

This patch add a section to the os-collect-config.conf template so that
the 'heat' collector can get proper configuration arguments.

Change-Id: I070929fd3cee6683b9ec1f9b6772f9fb076f835b
Closes-Bug: #1334581
Add psmisc package to ironic-conductor

A recent change to Ironic (https://review.openstack.org/#/c/90126/) introduces
a dependency on the fuser utility which is provided by the psmisc package.
This adds it to the package dependencies of ironic-conductor in case it is not
included in the base distro install.

Change-Id: I4dbc4a661962aa496194f2e8bae0d330af1444bd
cinder-volume: install qemu-img for conversions

Updates the cinder-volume element so that it installs the
qemu-img package. This is required in order to support
boot from volume conversions from Glance images (qcow2).

Change-Id: I1c6fb4692166b173092395967ffe9fe88ffdb602
Partial-bug: #1340479
Create/configure cinder's image_conversion_dir

Updates the cinder element to provide a new top level configuration
for cinder.image_conversion_dir. We are doing this as a top level
config because we also want to create this directory on disk as
well... and using os-apply-config to supply that default makes
sense. (using the pass-thru config would seem to be a bad choice
for this given we need to create a directory if it is set).

The cinder-volume element has been updated to create the
configured image_conversion_dir. If no image_conversion_dir
the default value is created at /mnt/state/var/lib/cinder/conversion.

Change-Id: Ibe8c20b7c815bb84d40a8593e51e82be95e01ec0
Closes-bug: #1340479
Permit specification of host in stunnel templates

While we can in principle do this already, there is a bug (1344284)
in heat which breaks our ability to calculate an appropriate unified
line from within heat. Instead, we can pass separate metadata to
os-apply-config and avoid this bug (which has no straight forward
fix).

Change-Id: I820862982afee07d85f1f0ad02b08cd5b0f35e49
Related-Bug: #1344284
mysql: call os-svc-enable

When configuring MySQL we should always auto-start the MySQL
daemon on startup. This prevents breaking simple use cases
like rebooting nodes, etc.

Change-Id: I15e54f54cbda2f030215f18da12f8a07ada4ca4d
Closes-bug: #1343329
Additional SELinux scripts

Created wrapper scripts around semanage fcontext and
restorecon commands.

For a lay person, these scripts are easier to understand. We also
check if SELinux is available within the script, so it will reduce
the amount of code currently in the SELinux orc scripts when they
are refactored.

Change-Id: I7fdd7d52e255a50d4900f35aba4b3390c68e6651
Add script to prepare a ci-overcloud

Script what needs to be done in order to prepare a ci-overcloud for CI
Currently a WIP, a few things still need to be ironed out. Also run this
at the end of deploy-ci-overcloud, it currenlty hardcoded to the HP
region but so it the rest of deploy-ci-overcloud.

Co-Authored-By: Robert Collins <rbtcollins@hp.com>
Change-Id: I461a840710625294a2aef1a1e08a3ed852e946ab
Move te-broker default IP address to 1.254

We're moving it to the end of the range to make deploys easier.
At the low end it races with dhcp agents and so forth.

Change-Id: I34600d127ff5b43c775bea07f7217cdc875b8e6a
Merge "Create/configure cinder's image_conversion_dir"
Merge "cinder-volume: install qemu-img for conversions"
Merge "Additional SELinux scripts"
Merge "mysql: call os-svc-enable"
Reserve the keystone high port out of ephemeral

The Keystone high port of 35357 is within the range Linux uses as
the ephemeral port range to reply to connections. Reserve it by
utilising the sysctl element.

Change-Id: I88cef5d95820e1ccf9501ef15ca2ace6efb516c3
Closes-Bug: #1330289
Merge "Add script to prepare a ci-overcloud"
Merge "Move te-broker default IP address to 1.254"
Merge "Permit specification of host in stunnel templates"
Merge "Add psmisc package to ironic-conductor"
Pull in patched eventlet to fix Second Simultaneous errors

We have patched eventlet to resolve the issues around
Second simultanous read errors. Pulling in the eventlet
pull request here.

This is a temporary workaround until the changes get merged
into eventlet and released at which point this will be dropped.

Closes-bug: #1308079
Closed-bug: #1229475
Closed-bug: #1308045
Change-Id: I0495f8c443429d9bdbbd97d46fe9a8e180b867ee