please correct validation for same.. right now you checking against
disbursement date.


On Tue, Apr 22, 2014 at 12:53 PM, andrew-dzak <notifications@github.com>wrote:

> In
> mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/domain/Loan.java:
>
> > +
> > +        loanTransaction.updateLoan(this);
> > +
> > +        final boolean isTransactionChronologicallyLatest = isChronologicallyLatestRepaymentOrWaiver(loanTransaction, this.loanTransactions);
> > +
> > +        if (loanTransaction.isNotZero(loanCurrency())) {
> > +            this.loanTransactions.add(loanTransaction);
> > +        }
> > +
> > +        if (!loanTransaction.isRecoveryRepayment()) {
> > +            final String errorMessage = "A transaction of type recovery repayment was expected but not received.";
> > +            throw new InvalidLoanTransactionTypeException("transaction", "is.not.a.recovery.repayment.transaction", errorMessage);
> > +        }
> > +
> > +        final LocalDate loanTransactionDate = loanTransaction.getTransactionDate();
> > +        if (loanTransactionDate.isBefore(getDisbursementDate())) {
>
> Hi Recovery payment is only allowed on the written off date or after the
> written off date. kind regards Andrew
> … <#1458851d514ca8ff_>
> On Fri, Apr 18, 2014 at 9:44 AM, pramod <notifications@github.com> wrote:
> In
> mifosng-provider/src/main/java/org/mifosplatform/portfolio/loanaccount/domain/Loan.java:
> > + > + loanTransaction.updateLoan(this); > + > + final boolean
> isTransactionChronologicallyLatest =
> isChronologicallyLatestRepaymentOrWaiver(loanTransaction,
> this.loanTransactions); > + > + if
> (loanTransaction.isNotZero(loanCurrency())) { > +
> this.loanTransactions.add(loanTransaction); > + } > + > + if
> (!loanTransaction.isRecoveryRepayment()) { > + final String errorMessage =
> "A transaction of type recovery repayment was expected but not received.";
> > + throw new InvalidLoanTransactionTypeException("transaction",
> "is.not.a.recovery.repayment.transaction", errorMessage); > + } > + > +
> final LocalDate loanTransactionDate = loanTransaction.getTransactionDate();
> > + if (loanTransactionDate.isBefore(getDisbursementDate())) { can it be
> allowed before written off date? -- Reply to this email directly or view it
> on GitHub<
> https://github.com/openMF/mifosx/pull/864/files?utm_campaign=website&utm_source=sendgrid.com&utm_medium=email#r11765990>
> .
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openMF/mifosx/pull/864/files#r11840976>
> .
>



-- 
Regards,
Pramod