Cc pdlogs 61

Updated after review comments for the ENT feature.  
Modified the messages to capitalize acronyms.  
Removed unnecessary whitespace.  
Added full stop to end of each part of the message.  
Actions are numbered if there is more than one action.  This separates the individual actions.
Separated the log definitions with a blank line to make them more readable.  
Ran astyle (according to the coding standards) against sprout_ent_definitions.h.
Fixed header file inconsistencies.
The review comment had: "A lot of the logs still say 'report issue to support' or something similar. This just isn't suitable for Project Clearwater."
The language was kept the same as this is what is done for the SNMP alarm definitions.  The associated documentation should identify the Metaswitch support team for ClearwaterCore and the Clearwater mailing list for Clearwater.
Removed signalnames.cpp.  The signal call name is now obtained from the strsignal call.
I got with Doug and he added it to the CC repo.  I am in the process of testing now.  I used boost_filesystem and boost_system on sprout, homestead, and ralf.  I avoided chronos as it does not seem to reference external include files in the Makefile.  I hesitated to make a precedent here.  It also does not seem to cause any harm.

From: Andy Caldwell [mailto:notifications@github.com]
Sent: Friday, December 19, 2014 7:10 AM
To: Metaswitch/sprout
Cc: David Collins
Subject: Re: [sprout] Cc pdlogs 61 (#895)


In sprout/sprout_base.mk<https://github.com/Metaswitch/sprout/pull/895#discussion-diff-22103541>:

> @@ -114,7 +114,8 @@ LDFLAGS += -lmemcached \

>             -levent \

>             -levent_pthreads \

>             -lcurl \

> -           -lsas

> +           -lsas \

> +           -lboost_filesystem

I agree. That level of "paranoia" prevents projects exploding in complexity and is a reasonable safeguard.

In this case, I think there are some mitigating facts. Although boost_filesystem is a new dependency, we already make use of various other boost libraries so we're pretty comfortable that the quality is there and we've already solved the problem of ensuring boost libraries are available alongside ClearwaterCore.

—
Reply to this email directly or view it on GitHub<https://github.com/Metaswitch/sprout/pull/895/files#r22103541>.