work on data controller