Revert 251206 "Fixes crashes wrt to the maximize button when:"

> Fixes crashes wrt to the maximize button when:
> - A user hovers the minimize button with the mouse then taps the snap left / snap right button
> - When the MaximizeBubbleFrameState computed by GetMaximizeBubbleFrameState() changes while the maximize button help bubble is visible due to the work area bounds changing (See comment #6 in bug)
> 
> BUG=342867
> TEST=FrameMaximizeButtonTest.MaximizeBubbleMouseHoverAndTouch
> 
> Review URL: https://codereview.chromium.org/160493004

Reverting as broke compile on windows:

[2431/3743] CXX
obj\chrome\browser\extensions\api\cast_channel\browser_extensions.cast_auth_util_nss.obj
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\caption_buttons\ash.maximize_bubble_controller.obj.rsp /c
..\..\ash\wm\caption_buttons\maximize_bubble_controller.cc
/Foobj\ash\wm\caption_buttons\ash.maximize_bubble_controller.obj
/Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\ash.custom_frame_view_ash.obj.rsp /c
..\..\ash\wm\custom_frame_view_ash.cc
/Foobj\ash\wm\ash.custom_frame_view_ash.obj /Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\caption_buttons\ash.frame_caption_button_container_view.obj.rsp
/c ..\..\ash\wm\caption_buttons\frame_caption_button_container_view.cc
/Foobj\ash\wm\caption_buttons\ash.frame_caption_button_container_view.obj
/Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\caption_buttons\ash.maximize_bubble_controller_bubble.obj.rsp
/c ..\..\ash\wm\caption_buttons\maximize_bubble_controller_bubble.cc
/Foobj\ash\wm\caption_buttons\ash.maximize_bubble_controller_bubble.obj
/Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe
"C:\Program Files (x86)\Microsoft Visual Studio
11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC
@obj\ash\wm\caption_buttons\ash.frame_maximize_button.obj.rsp /c
..\..\ash\wm\caption_buttons\frame_maximize_button.cc
/Foobj\ash\wm\caption_buttons\ash.frame_maximize_button.obj
/Fdobj\ash\ash.cc.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73)
:error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' :
method with override specifier 'override' did not override any base
class methods
ninja: build stopped: subcommand failed.

from: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/14916/steps/compile/logs/stdio#error1

TBR=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/165283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251217 0039d316-1c4b-4281-b951-d872f2087c98
Use udev for serial device enumeration on Linux

Device enumeration code has been lifted from
src/chrome/browser/extensions/api/serial and moved into src/device/serial.

The enumeration impl for Linux now uses udev to enumerate devices matching the
"tty" subsystem, rather than matching /dev node name patterns.

The Windows implementation remains effectively unchanged, and the Mac
implementation has had its /dev pattern filter relaxed to catch devices of the
more generic forms "/dev/tty.*" and "/dev/cu.*".

BUG=334698

Review URL: https://codereview.chromium.org/158063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251218 0039d316-1c4b-4281-b951-d872f2087c98
Few changes to cast socket:
1. Log IP address of the receiver in every message to help with debugging
2. Remove dependency on cast_channel_api.pb.h from cast_socket.h to avoid
   flaky build issue
3. Log lower priority messages at level 2

Review URL: https://codereview.chromium.org/160973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251219 0039d316-1c4b-4281-b951-d872f2087c98
Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/165593002/)

Reason for revert:
https://chromium-review.googlesource.com/#/c/185937/ just got landed and this CL can go in now. 

Original issue's description:
> Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/163793004/)
> 
> Reason for revert:
> https://chromium-review.googlesource.com/#/c/185937/ has to go in first. 
> 
> 
> Original issue's description:
> > Turn on icu_use_data_file_flag on CrOS
> > 
> > See also https://chromium-review.googlesource.com/#/c/185937/
> > 
> > The switch has to be turned on in two places (chromeos-chrome.ebuild and
> > build/common.gypi). One or the other can get landed separately, though.
> > 
> > BUG=72633
> > TEST=net_unittests:*IDN* and base_unittests:*String*
> > TBR=mark
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251213
> 
> TBR=mark@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=72633
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251214

TBR=mark@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=72633

Review URL: https://codereview.chromium.org/164333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251220 0039d316-1c4b-4281-b951-d872f2087c98
Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId.

The functionality is the same, just moving the code to a new place.

NOTRY=True
BUG=333995
R=bauerb@chromium.org, brettw@chromium.org, joaodasilva@chromium.org, nhiroki@chromium.org, noms@chromium.org, rlarocque@chromium.org

Review URL: https://codereview.chromium.org/150003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251221 0039d316-1c4b-4281-b951-d872f2087c98
[ProtocolHandlers] Add a permission bubble client for RPH requests.

R=benwells@chromium.org
BUG=332115

Review URL: https://codereview.chromium.org/152143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251222 0039d316-1c4b-4281-b951-d872f2087c98
Remove CloudPrintAccountManager.

It is an unused class from back when we thought we may want to have
multi-account support in the devices page.

BUG=

Review URL: https://codereview.chromium.org/163943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251223 0039d316-1c4b-4281-b951-d872f2087c98
Fix accessibility_unittests.

BUG=343580
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/163233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251224 0039d316-1c4b-4281-b951-d872f2087c98
Add missing x11 checks in StickyKeysHandler.

We guard all calls to AppendNativeEventMask with X11 platform checks.
It appends native masks and are defined only on X11 platform. This CL
adds the missing check in AppendNativeEventMask.

Review URL: https://codereview.chromium.org/164223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251225 0039d316-1c4b-4281-b951-d872f2087c98
Add missing break statement
Add a missing break statement in developer_private_api.cc (I'm actually shocked
this didn't cause runtime errors).

TBR=finnur@chromium.org

Review URL: https://codereview.chromium.org/163863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251226 0039d316-1c4b-4281-b951-d872f2087c98
OOBE localization browser test

Test that the expected languages and keyboard layouts are available in the
OOBE network screen.

BUG=327034
R=nkostylev@chromium.org, achuith@chromium.org

Review URL: https://codereview.chromium.org/153473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251227 0039d316-1c4b-4281-b951-d872f2087c98
Revert of Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId. (https://codereview.chromium.org/150003004/)

Reason for revert:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GTK%20Builder/builds/497

Original issue's description:
> Replace PO2TS::GetPrimaryAccountId() with SMB::GetAuthenticatedAccountId.
> 
> The functionality is the same, just moving the code to a new place.
> 
> NOTRY=True
> BUG=333995
> R=bauerb@chromium.org, brettw@chromium.org, joaodasilva@chromium.org, nhiroki@chromium.org, noms@chromium.org, rlarocque@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251221

TBR=joaodasilva@chromium.org,noms@chromium.org,bauerb@chromium.org,rlarocque@chromium.org,sky@chromium.org,nhiroki@chromium.org,brettw@chromium.org,rogerta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=333995

Review URL: https://codereview.chromium.org/165543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251228 0039d316-1c4b-4281-b951-d872f2087c98
Update NaCl SDK build for new location of irt_ppapi.h header file

This file is being added to the Chromium repo and removed from the NaCl repo.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3787
TEST=NaCl SDK trybots
R=binji@chromium.org, bradnelson@google.com

Review URL: https://codereview.chromium.org/164323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251230 0039d316-1c4b-4281-b951-d872f2087c98
Update for reduced static initializers after r251212

BUG=341941,94925
TBR=vclarke@chromium.org

Review URL: https://codereview.chromium.org/165803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251232 0039d316-1c4b-4281-b951-d872f2087c98
Update description of fullscreen-within-tab experiment in about:flags.

BUG=256870

Review URL: https://codereview.chromium.org/165063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251233 0039d316-1c4b-4281-b951-d872f2087c98
Creates a new helper function to extract search terms from the URL irrespective of the availability of InstantExtendedEnabledParam. 

Previously, InstantSearchPrerenderer invoked chrome::GetSearchTermsFromURL() to extract search terms from the search page url. chrome::GetSearchTermsFromURL() returns a valid non-empty string iff the url has an InstantExtendedEnabledParam("&espv"). If the query extraction is turned off, the search request url will not have an InstantExtendedEnabledParam. In those cases, chrome::GetSearchTermsFromURL() returns an empty string to the InstantSearchPrerenderer.

To extract search terms for InstantSearchPrerenderer, we should not depend on the query extraction flag or the Instant support state of the page.

Follow up of crrev.com/151813002.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/141893009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251234 0039d316-1c4b-4281-b951-d872f2087c98
Mojo: Add a threaded perf test for (local) message pipes.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/164693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251235 0039d316-1c4b-4281-b951-d872f2087c98
Part 4 of search provider refactoring.

Moves AddMatchToMap method to the common base class. Adds method parameters
so that both SearchProvider and ZeroSuggestProvider can use this method.

For SearchProvider this is a pure refactoring. I added some helper classes
in SearchProvider to avoid duplicating code.

For ZeroSuggestProvider, this introduces some additional functionality on
top of what it used to have. Mainly the method may record additional metadata on
the AutocompleteMatch. This metadata is not currently used by zero suggest
provider and as far as I can tell will not in any way affect the operation
of zero suggest provider today. In the future, some of the metadata
recorded will actually be useful (e.g. I am planning to take advantage of
deletion_url).

BUG=338955
TBR=mpearson

Review URL: https://codereview.chromium.org/158053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251236 0039d316-1c4b-4281-b951-d872f2087c98
Docserver: Fix invalid path usage in CloudStorageFileSystem.

R=mangini@chromium.org
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/165353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251237 0039d316-1c4b-4281-b951-d872f2087c98
cc: Clean up iterator template to only take 1 parameter.

LayerIterator takes 4 parameters. One is the FrontToBack ordering
but that is now the only option. The other 3 are for the type of layers,
render surfaces, and the render surface layer list. The latter two are
now already available as typedefs off of Layer and LayerImpl, so we
only need Layer/LayerImpl in the template arguments.

R=enne
BUG=YAK

Review URL: https://codereview.chromium.org/156603005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251238 0039d316-1c4b-4281-b951-d872f2087c98