fetch2/wget: Fix downloadfilename functionality

Some of the previous cleanups broke the downloadfilename functionality.
This change fixes the code to ensure the commandline is correctly built.

Thanks Kristof Robot <krirobo@gmail.com> for reporting the issue.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
toastergui: fix task executed status display

The proper way to get a display-able value
in Django is to use a model method instead of clutter
the template with if/else.

	[YOCTO #5641]

Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
toasterui: adding new task outcome empty

In order to separate tasks with invalid states from the
no exec tasks, we add a new value OUTCOME_EMPTY for the tasks.

OUTCOME_EMPTY has the same value as OUTCOME_NA as to maintain
compatibility with already existing builds. New value for
OUTCOME_NA can be used to detect tasks with invalid states, i.e.
it should never appear after finishing a build.

Fixing noexec tasks outcomes.

	[YOCTO #5763]

Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
toaster: mark dependency packages

We need to mark the package entries that are
created solely for dependency tracking purposes.

In order to avoid altering the database schema,
we mark the dependency targets with size = -1, since
this is not a valid size anyway and makes for easy
filtering.

	[YOCTO #5803]

Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
toaster: array-assignment fix from Chome

Apparently the JS engine in Chrome can't handle assignments to an array,
so I'm patching this up by using an intermediate array to hold the
values.

Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
bb/ui: store_dependency_information optimization

This optimization is in support of the bug #5485. The function called
at the beginning of every build: store_dependency_information was taking
approximately 20sec and it was delaying the arrival of events from the
event queue. The change minimizes the calls to _save_a_task(),
reducing the time to half.

Signed-off-by: Marius Avram <marius.avram@intel.com>
toasterui: task data structure in toasterui

We update the structure used to hold interm task data,
before it is written to the database, to lower the changes
of key collision.

This will also lead to a cleaner data structure and easier
inspection.

Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
toasterui: add asserts on expected values

We add assert statements that validate expectations of
correct values and context when the data collection code is running.

These checks will help pinpointing unexpected data or
call flows, reducing debugging time.

Also contains a couple of very small fixes discovered through
these checks, including a virtual:native conflict with
regular tasks.

	[YOCTO #5553]

Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
toaster: extend Tasks to include Time, Disk IO, and CPU Usage

Update the All Tasks page to also cover the Time, Disk I/O, and
CPU Usage pages. Add filter count header support, and fix minor column
enablements.

[YOCTO #4387]

Signed-off-by: David Reyna <David.Reyna@windriver.com>
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
toaster: Remove inline styles in h1

The templates bpackage.html, recipes.html and build.html included
an inline style declaration in the div containing the h1
tag to add a top margin of 40px. The extra top margin
is unnecessary in bpackage.html and recipes.html, but nicely
separates the Recent builds and All builds sections in build.html.

The changes remove the inline style declaration and create
a .top-air class in default.css to include the extra top margin
when needed, i.e. in the build.html template.

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
toaster: Set correct string for missed sstate attempts

Replace 'Missed' with 'File not in cache'in models.py

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
toaster: Set the right styles for definition lists

In the task details page, our labels are quite long and
the default width of the dt elements in the .dl-horizontal
class is too small. Changing the width to 200px, and the
left margin of the dd element to 220px.

Changing the bootstrap.min.css file is not ideal (ok, is
a pretty bad hack), but it is the only way to keep the
nice responsive styles for those definition lists.

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
toaster: Add .muted class to disabled checkboxes

In the edit columns menu, the checkboxes for the columns in the
minimum table are disabled. To better communicate visually
the disabled state, this change applies the .muted class
to the labels of those checkboxes.

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
toaster: Hide the applied filter tooltip on click

When you apply a filter, we show you a tooltip on hover
that tells you which filter you have applied and allows you
to clear it quickly. That tooltip does not disappear
straight away if you click on the filter button: it hangs
in there because the tooltip has a delay specified on
hide. The effect is quite annoying.

This change to main.js makes sure the tooltip disappears when
you click the filter button.

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
toaster: Change help text for Section

The help text for the Section information in the
recipes table and the recipe details page said
"packages" instead of recipes, and it said there
were 5 possible values for the SECTION variable
(which is not true).

Changed to "The section in which recipes should
be categorised"

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
toaster: Change popover headings in recipes table

In the recipes table, dependencies and reverse dependencies
are shown inside a popover. The popover headings did not
match the table headings, so changed to "dependencies" and
"reverse dependencies" as per the design spec.

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
toaster: Sort packages and dependencies in recipe.html

The tables in the Packages, Build dependencies and
Reverse build dependencies tabs in the recipe details
pages (template recipe.html) should be sorted by package
name and recipe name respectively.

This change adds the sorting.

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
toaster: Fix breadcrumb date format in detail pages

The template basebuilddetailpage.html had the completed
on date in the breadcrumb set to naturaltime. Changed to
d/m/y H:i to match the date format in the basebuildpage.html
template, so that breadcrumbs display the same date format across
all pages.

Signed-off-by: Belen Barros Pena <belen.barros.pena@intel.com>
toaster: Bug fix in reload page with parameters

Fix the bug in reload_params function that was failing when
the page URL did not have any parameters.

Signed-off-by: Ravi Chintakunta <ravi.chintakunta@timesys.com>
toaster: View detailed information about a task

Information about a task is displayed depending on it's execution
status and outcome status.

Edited to iterate through all possible entries for related setscene
tasks.

[YOCTO #4282]

Signed-off-by: Ravi Chintakunta <ravi.chintakunta@timesys.com>
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>