I agree with this comment. However, I can't fix it this go around. Perhaps
we could also implement a set of target observer plugins for the cameras.
The target recognition issue is even bigger than selecting which target.
Symetric targets like checkerboards and circle grids have the issue that
the correspondence may be reversed depending on the viewing angle. This
must be accounted for by the observer for extrinsic calibration to work
correctly. We should address both these issues in the next round.


On Wed, Apr 30, 2014 at 5:48 PM, Shaun Edwards <notifications@github.com>wrote:

> In
> industrial_extrinsic_cal/include/industrial_extrinsic_cal/ros_camera_observer.h:
>
> > @@ -45,134 +45,147 @@
> >   */
> >  namespace pattern_options
> >  {
> > -enum pattern_options_
> > -{
> > -  Chessboard = 0, CircleGrid = 1, ARtag = 2
> > -};
> > +  enum pattern_options_
>
> This enum may prove problematic in the future if we ever add a pattern
> type. We would need to edit the code and in particular the camera observer
> (which wouldn't be obvious). A base pattern recognition class with specific
> implementations might address this.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ros-industrial/industrial_calibration/pull/26/files#r12170150>
> .
>