I'd think that a new PR for those refactorings might be a bit cleaner; but
is just my personal preference


On Wed, Mar 19, 2014 at 12:54 PM, Bruno Oliveira
<notifications@github.com>wrote:

> In src/main/java/org/jboss/aerogear/unifiedpush/SenderClient.java:
>
> > @@ -65,6 +82,9 @@ private SenderClient(Builder builder) {
> >          this.proxyUser = builder.proxyUser;
> >          this.proxyPassword = builder.proxyPassword;
> >          this.proxyType = builder.proxyType;
>
> +1 for moving it, not sure about a new PR. I think we can do it here
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/aerogear/aerogear-unifiedpush-java-client/pull/36/files#r10745617>
> .
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf