2010-10-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: refactoring of native breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=47360

        Make DOM, EventListener and XHR breakpoints subclasses of NativeBreakpoint class.
        Move stuff that depends on breakpoint type to corresponding subclass.

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::setNativeBreakpoint):
        (WebCore::InspectorController::removeNativeBreakpoint):
        (WebCore::InspectorController::findEventListenerBreakpoint):
        (WebCore::InspectorController::findXHRBreakpoint):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::setDOMBreakpoint):
        (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
        (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
        (WebCore::InspectorDOMAgent::didRemoveDOMNode):
        (WebCore::InspectorDOMAgent::removeBreakpointsForNode):
        (WebCore::InspectorDOMAgent::createBreakpointId):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::willDispatchEventImpl):
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager):
        (WebInspector.BreakpointManager.prototype.reset):
        (WebInspector.BreakpointManager.prototype.createDOMBreakpoint):
        (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint):
        (WebInspector.BreakpointManager.prototype.createXHRBreakpoint):
        (WebInspector.BreakpointManager.prototype._removeNativeBreakpoint):
        (WebInspector.BreakpointManager.prototype._setNativeBreakpointOnBackend.didSetNativeBreakpoint):
        (WebInspector.BreakpointManager.prototype._setNativeBreakpointOnBackend):
        (WebInspector.BreakpointManager.prototype.debuggerPaused):
        (WebInspector.BreakpointManager.prototype.debuggerResumed):
        (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints.restoreBreakpointsForNode):
        (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
        (WebInspector.NativeBreakpoint):
        (WebInspector.NativeBreakpoint.prototype.remove):
        (WebInspector.NativeBreakpoint.prototype.get _frontendId):
        (WebInspector.NativeBreakpoint.prototype.get _type):
        (WebInspector.NativeBreakpoint.prototype._compare):
        (WebInspector.NativeBreakpoint.prototype._onRemove):
        (WebInspector.DOMBreakpoint):
        (WebInspector.DOMBreakpoint.prototype.click):
        (WebInspector.DOMBreakpoint.prototype.compareTo):
        (WebInspector.DOMBreakpoint.prototype.populateLabelElement):
        (WebInspector.DOMBreakpoint.prototype.populateStatusMessageElement.formatters.s):
        (WebInspector.DOMBreakpoint.prototype.populateStatusMessageElement.append):
        (WebInspector.DOMBreakpoint.prototype.populateStatusMessageElement):
        (WebInspector.DOMBreakpoint.prototype._condition):
        (WebInspector.DOMBreakpoint.prototype._onRemove):
        (WebInspector.EventListenerBreakpoint):
        (WebInspector.EventListenerBreakpoint.prototype.compareTo):
        (WebInspector.EventListenerBreakpoint.prototype.label):
        (WebInspector.EventListenerBreakpoint.prototype.populateStatusMessageElement):
        (WebInspector.EventListenerBreakpoint.prototype._condition):
        (WebInspector.XHRBreakpoint):
        (WebInspector.XHRBreakpoint.prototype.compareTo):
        (WebInspector.XHRBreakpoint.prototype.populateLabelElement):
        (WebInspector.XHRBreakpoint.prototype.populateStatusMessageElement):
        (WebInspector.XHRBreakpoint.prototype._condition):
        (WebInspector.domBreakpointTypeLabel):
        (WebInspector.domBreakpointTypeContextMenuLabel):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.BreakpointItem):
        (WebInspector.BreakpointItem.prototype._breakpointClicked):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._populate):
        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane):
        (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
        (WebInspector.CallStackSidebarPane.prototype._breakpointHit):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):
        (WebInspector.DOMAgent.prototype._setDocument):
        (WebInspector.DOMAgent.prototype._removeBreakpoints):
        (WebInspector.childNodeRemoved):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.debuggerPaused):
        * inspector/front-end/inspector.js:
        (WebInspector.createDOMBreakpointsSidebarPane.breakpointAdded):
        (WebInspector.createDOMBreakpointsSidebarPane):
        (WebInspector.reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Shinichiro Hamaji  <hamaji@chromium.org>

        Update test expectations for r69564.

        fast/text/backslash-to-yen-sign-euc.html fails on Windows
        https://bugs.webkit.org/show_bug.cgi?id=47018

        * platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
        * platform/qt/fast/text/backslash-to-yen-sign-euc-expected.txt:
        * platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Alexander Pavlov  <apavlov@chromium.org>

        [Chromium] Unreviewed, build fix.

        Rebaseline http/tests/security/cross-frame-access-get.html for chromium-mac and chromium-win

        * platform/chromium-mac/http/tests/security/cross-frame-access-get-expected.txt:
        * platform/chromium-win/http/tests/security/cross-frame-access-get-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Juha Savolainen  <juha.savolainen@weego.fi>

        Reviewed by Antti Koivisto.

        [Qt] Adding Qt WebKit2 API for zooming.
        https://bugs.webkit.org/show_bug.cgi?id=47539

        Adding zoom methods to QWKPage.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::textZoomFactor): Added
        (QWKPage::setTextZoomFactor): Added
        (QWKPage::pageZoomFactor): Added
        (QWKPage::setPageZoomFactor): Added
        (QWKPage::setPageAndTextZoomFactors): Added
        * UIProcess/API/qt/qwkpage.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Alexander Pavlov  <apavlov@chromium.org>

        [Chromium] Unreviewed, build fix.

        Rebaseline inspector/console-dir-global.html to follow r69553.
        Rebaseline some SVG tests on chromium-mac to follow r69563.

        * platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
        * platform/chromium-mac/svg/custom/gradient-with-1d-boundingbox-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
        * platform/chromium-win/inspector/console-dir-global-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Rubber-stamped by Dirk Schulze.

        Update of Leopard pixel test baseline baseline after r69517.

        * platform/mac-leopard/svg/W3C-SVG-1.1-SE: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum: Added.
... 


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, build fix.

        Build fix for r69567.

        * inspector/dom-breakpoints.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix class vs struct forward declaration issues in WebKit2 observed when using clang.

* Scripts/webkit2/messages.py: Add WebCore::ViewportArguments to the set of structs.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix the 32-bit WebKit2 build.

WebKit2:

* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Change currentIndex to be of
type CFIndex and specify kCFNumberCFIndexType when calling CFNumberGetValue. This avoids a warning
when comparing currentIndex with another variable of type CFIndex later in the function.

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns.
(setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Alexander Pavlov  <apavlov@chromium.org>

        [Chromium] Unreviewed, clean up chromium-mac SVG test expectations.

        Some tests have started to pass after a series of SVG test rebaselines.
        Remove stale failure expectations.

        * platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Alexander Pavlov  <apavlov@chromium.org>

        [Chromium] Unreviewed, clean up chromium-win SVG test expectations.

        Remove stale expectations for fixed or rebaselined SVG tests on Windows.

        * platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Implement http locking in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=47072

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-10-12
Reviewed by Tony Chang.

* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
* Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Andreas Kling  <kling@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Clipping problem viewing SVG with WebKit
        https://bugs.webkit.org/show_bug.cgi?id=29596

        SVG path clipping (via GraphicsContext::clipPath()) was done using the
        Qt::ReplaceClip mode (default) instead of Qt::IntersectClip. This led
        to misrenderings when nesting multiple clip paths.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::clipPath):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Bring WebKit2 .vcproj files up-to-date with reality

* win/WebKit2.vcproj:
* win/WebKit2Generated.vcproj:
Added missing files, removed non-existent files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WTR] Checking the path of the injected bundle is bogus
        https://bugs.webkit.org/show_bug.cgi?id=47541

        * WebKitTestRunner/qt/TestControllerQt.cpp:
        (WTR::isExistingLibrary): Added (static helper).
        Extend the path with the appropriate suffix(es) on the
        platform and check that the file exists.
        (WTR::TestController::initializeInjectedBundlePath):
        There were two bugs with the path checking:
            - the condition should have been inverted
            - QLibrary::fileName does not give back the filename
              with the library suffix so we cannot check
              that existance of the file this way.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Editing commands should not be executed on non-editable content.
        https://bugs.webkit.org/show_bug.cgi?id=47426

        * fast/events/scroll-after-click-on-tab-index-expected.txt: Added.
        * fast/events/scroll-after-click-on-tab-index.html: Added.
2010-10-12  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Editing commands should not be executed on non-editable content.
        https://bugs.webkit.org/show_bug.cgi?id=47426

        Remove calls to editor()->command() when we are not in editable content.
        There is no value in doing that, and in some cases, it prevents scrolling.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Martin Robinson  <mrobinson@igalia.com>

        Rebaselined a failing tests. Unskipped editing tests that are passing and
        categorized the remaining failing editing tests.

        * platform/gtk/Skipped: Updated skipped list.
        * platform/gtk/editing/style/apply-through-end-of-document-expected.txt: Added.
        * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Rebaselined.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add BinarySemaphore class to CoreIPC and use it in Connection::waitForSyncReply
https://bugs.webkit.org/show_bug.cgi?id=47526

Reviewed by Sam Weinig.

* Platform/CoreIPC/BinarySemaphore.cpp: Added.
* Platform/CoreIPC/BinarySemaphore.h: Added.
Add BinarySemaphore class.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::waitForSyncReply):
(CoreIPC::Connection::processIncomingMessage):
Use the binary semaphore and the newly added m_pendingSyncRepliesMutex.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add new files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Tony Chang  <tony@chromium.org>

        Unreviewed, trying to fix NRWT on Windows.

        * Scripts/webkitpy/layout_tests/port/http_lock.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-10-12  Dave Moore  <davemoore@chromium.org>

        Reviewed by Tony Chang.

        Use new WebThemeEngine api on chromium / linux to draw scrollbars.
        https://bugs.webkit.org/show_bug.cgi?id=47473

        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
2010-10-12  Dave Moore  <davemoore@chromium.org>

        Reviewed by Tony Chang.

        Use new WebThemeEngine api on chromium / linux to draw scrollbars.
        https://bugs.webkit.org/show_bug.cgi?id=47473

        * public/WebThemeEngine.h: Removed.
        * chromium/src/ChromiumBridge.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69586 268f45cc-cd09-0410-ab3c-d52691b4dbfc