[messagefacility] Remove ELtsItem template function

Clang identified following problems with templated ELtsItem function:

- Function is void, but returns non-void
- It tries to access protected members of the supplied ELtsErrorLog
instance.

Searches in messagefacility itself and art suggest that this function
is never instantiated, and is thus obsolete. Remove function to
fix errors on Clang.
[messagefacility] Use updated fhiclcpp interfaces

Problem highlighted by Clang. MessageLoggerScribe's getAparameter
template member functions use old fhiclcpp::ParameterSet interfaces.
Suggests that these functions are never used. Several implementations
controlled by #ifdefs, of which only that inside `VALIDATE_ELSEWHERE`
is relevant.

Replace old fhiclcpp::ParameterSet access interfaces by relevant
modern ones in MessageLoggerScribe's getAparameter template method
under the VALIDATE_ELSEWHERE #ifdef.

TODO: Remove member functions if they are obsolete.
[messagefacility] Add needed sys/time.h header

Problem identified on Apple Clang - use of timeval requires sys/time.h
header to be included.

Add include for sys/time.h in
messagefacility/MessageLogger/MessageFacilityMsg.h
[messagefacility] Use consistent #ifdef/define name