Oh, that's probably my fault. I tweaked some stuff pertaining to PgmArg and
must have done it wrong because I didn't know what that did. I will do as
you suggest tomorrow. Feel free to close this diff unmerged.
On May 14, 2014 10:05 PM, "Ömer Sinan Ağacan" <notifications@github.com>
wrote:

> In src/javasources/KTool/src/org/kframework/utils/StringUtil.java:
>
> > +                sb.append("' ");
> > +            }
> > +            sb.deleteCharAt(sb.length() - 1);
> > +            return sb.toString();
> > +        } else if (os == OS.WIN) {
> > +            StringBuilder sb = new StringBuilder();
> > +            for (String arg : args) {
> > +                sb.append('"');
> > +                sb.append(StringUtils.replace(StringUtils.replace(arg, "\\", "\\\\"), "\"", "\\\""));
> > +                sb.append("\" ");
> > +            }
> > +            sb.deleteCharAt(sb.length() - 1);
> > +            return sb.toString();
> > +        }
> > +        throw new IllegalArgumentException("unsupported OS");
> > +    }
>
> I'm pretty sure this was handled before. This is what
> org.kframework.ktest.QuoteHandling class for, but that class looks unused
> right now. I just searched in commit history to see why quoting is removing
> and when is it removed.
>
>    - ca29b75#diff-39b4d4e21743e2de4c36b28c757e87beL59<https://github.com/kframework/k/commit/ca29b751d823c16f86ef59aeb8a4b15b6f9e9c96#diff-39b4d4e21743e2de4c36b28c757e87beL59>
>    - f7b1e89#diff-a5cf3aaf006fff3d93af758c62573efdL162<https://github.com/kframework/k/commit/f7b1e896c92794ff3a0aee47eaede2ff1e41a214#diff-a5cf3aaf006fff3d93af758c62573efdL162>
>
> This two commits(relevant lines are annotated in the links) removes uses
> of quoteArgument. There should be at least one more removal of this
> method(for PDF command printing), but I couldn't find it.
>
> I have no idea why it was removed before but why not put these lines back
> instead of implementing same thing again? (we now quoteArgument was
> working fine without problems) And why it was removed before?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/kframework/k/pull/445/files#r12672616>
> .
>