also logic to add attributes for properties
docs